Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Preserve loop binding metadata when inside a go block

Description

Description:
Currently this causes a reflection warning because core.async loses the type hint on the binding:

This is a problem since macros like `doseq` expand to similar code and cause reflection warnings

The attached patch preserves that metadata and removes the reflection warning

Patch: 0001-ASYNC-155-preserve-loop-binding-metadata.patch

Environment

None

Attachments

1

Activity

Show:

Alex Miller February 13, 2017 at 9:24 PM

Applied

Alex Miller February 13, 2017 at 9:24 PM

gotcha, thx

Nicola Mometto February 13, 2017 at 9:23 PM

No particular reason, `loop` would manifest the same issue aswell. I don't remember the details but I think I got to this minimal repro case by macroexpanding a doseq form and reducing the code to this, hence why `loop*` instead of `loop`

Alex Miller February 13, 2017 at 9:20 PM

Why are we using loop* in the example?

Nicola Mometto February 13, 2017 at 9:13 PM

Fixed the example, I omitted by accident a call to (chan) while copy pasting from the repl

Completed

Details

Assignee

Reporter

Approval

Triaged

Patch

Code

Priority

Created December 15, 2015 at 11:48 PM
Updated February 13, 2017 at 9:24 PM
Resolved February 13, 2017 at 9:24 PM