onto-chan retains head of input sequence causing OutOfMemoryError

Description

onto-chan is holding on to the head of the input sequence as it is unfolded, resulting in an (eventual) OutOfMemoryError.

I've attached a diff showing changes I made to onto-chan that fixed the problem for me.

Environment

org.clojure/core.async 0.1.242.0-44b1e3-alpha

Attachments

1

Activity

Show:

Alex Miller February 14, 2017 at 4:35 PM

Duplicate of

Nicola Mometto December 16, 2015 at 12:12 AM

The fix for should fix this issue aswell and is more general

import August 11, 2015 at 6:00 AM

Comment made by: bclube

This issue might be caused by ASYNC-138.

Alex Miller August 10, 2015 at 9:22 PM

This seems like a viable change, but the patch needs a better test (even if not in the patch) and to be properly formatted for git apply (per http://dev.clojure.org/display/community/Developing+Patches).

Colin Taylor October 8, 2014 at 1:13 AM

Just to note, to-chan uses onto-chan so is similarly affected.
We ran into this, Brian's patch worked fine.

Duplicate

Details

Assignee

Reporter

Labels

Approval

Triaged

Patch

Code

Priority

Created November 6, 2013 at 7:08 AM
Updated February 14, 2017 at 4:35 PM
Resolved February 14, 2017 at 4:35 PM