core.async

queue-dispatcher should fall back to process.nextTick if setImmediate is not available

Details

  • Type: Defect Defect
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
  • Approval:
    Triaged

Description

discussion here:

https://groups.google.com/forum/#!searchin/clojurescript/nextTick/clojurescript/RW1FMv0UoPE/hsMHI4SLKXYJ

discussion of the differences between setImmediate and nextTick here:

http://stackoverflow.com/questions/15349733/setimmediate-vs-nexttick

it sounds to me like nextTick should be ok, but I'm not familiar with the design decisions in the current implementation

I'm happy to create a patch - will do that shortly.

  1. nextTick.patch
    08/Dec/13 8:52 PM
    0.6 kB
    Travis Vachon
  2. async_43.patch
    10/Dec/13 9:53 AM
    1 kB
    Travis Vachon

Activity

Hide
Travis Vachon added a comment -
Show
Travis Vachon added a comment - patch here: https://github.com/clojure/core.async/pull/40
Hide
Travis Vachon added a comment -

just the code, not entirely sure how to test this, but have tested manually in the parse.com cloud code environment

Show
Travis Vachon added a comment - just the code, not entirely sure how to test this, but have tested manually in the parse.com cloud code environment
Hide
Travis Vachon added a comment -

add git am able patch

Show
Travis Vachon added a comment - add git am able patch
Hide
Travis Vachon added a comment -

just want to ping this issue - anything else it needs to be mergable? I'm using a core.async fork at the moment and would love to get back on the main line!

Show
Travis Vachon added a comment - just want to ping this issue - anything else it needs to be mergable? I'm using a core.async fork at the moment and would love to get back on the main line!
Hide
David Nolen added a comment -

The patch probably needs updating - we've since switched to Google Closure for choosing the underlying dispatch functionality for the JavaScript environment.

Show
David Nolen added a comment - The patch probably needs updating - we've since switched to Google Closure for choosing the underlying dispatch functionality for the JavaScript environment.

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated: