core.cache

• Type: Defect
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: None
• Fix Version/s: None
• Component/s: None
• Labels:

  None
• Environment:

  Linux, Oracle JRE 1.6

"cell" can be null on this call to SoftReference.get():
https://github.com/clojure/core.cache/blob/master/src/main/clojure/clojure/core/cache.clj#L501

If the cache did not contain "item" in the call to (get cache item) in the let binding, but another thread pre-empts and adds it before the subsequent call to contains?, we'll attempt to call .get() on nil.

Would it perhaps be sufficient to just check whether cell is nil instead of calling contains? in the check on the previous line?

1. 

   0001-CCACHE-28-fixes-concurrency-bug-in-has.patch

   09/Feb/13 6:13 AM

   1 kB

   Paul Stadig

• Assignee:

  Fogus

  Reporter:

  James Aley

• Created:

  24/Oct/12 8:42 AM

  Updated:

  09/Feb/13 6:27 AM