Clojure

Converted from http://www.assembla.com/spaces/clojure/tickets/1
Attachments:
chunked-doseq.diff - https://www.assembla.com/spaces/clojure/documents/dyQbLWIiCr3RSfeJe5aVNr/download/dyQbLWIiCr3RSfeJe5aVNr
chunked-doseq-v2.diff - https://www.assembla.com/spaces/clojure/documents/ayZsEAIHer3OuReJe5afGb/download/ayZsEAIHer3OuReJe5afGb
chunked-concat.diff - https://www.assembla.com/spaces/clojure/documents/ddNltiJ1Gr3Q4TeJe5aVNr/download/ddNltiJ1Gr3Q4TeJe5aVNr
chunked-for.diff - https://www.assembla.com/spaces/clojure/documents/d1Zsv2Ke4r3QR8eJe5afGb/download/d1Zsv2Ke4r3QR8eJe5afGb

chouser@n01se.net said: [file:dyQbLWIiCr3RSfeJe5aVNr]: doseq with chunked seq support

chouser@n01se.net said: Is it ok to call chunk-rest before chunk-first is consumed?

Anyway, I must have done something terribly wrong. The doseq in chunked-doseq.diff passes all existing tests, but runs dramatically slower than the old doseq on both chunked and non-chunked seqs.

I didn't test performance until after I'd attached the patch, otherwise I would have kept it to myself.

chouser@n01se.net said: [file:ayZsEAIHer3OuReJe5afGb]: Add chunked seq support to doseq, v2

chouser@n01se.net said: file:chunked-doseq-v2.diff should be good to go. It's in the same performance ballpark as the pre-chunk doseq for unchunked seqs, and noticeably faster for chunked seqs. It passes all existing tests.

chouser@n01se.net said: (In [[r:1abb7a56de1678321054af7fce183184f06974dd]]) Add chunked seq support to doseq, v2. Refs #1

Branch: master

chouser@n01se.net said: set approval back to 'none', awaiting patches for more functions.

chouser@n01se.net said: [file:ddNltiJ1Gr3Q4TeJe5aVNr]: Add chunked seq support to concat

chouser@n01se.net said: [file:aIu4XoJ1Kr3OYMeJe5afGb]: Add chunked seq support to concat

chouser@n01se.net said: Added chunked seq support to concat: file:chunked-concat.diff

Because concat had been defined before any of the chunk fns, I moved the the chunk fns to much earlier in core.clj than they were. This also required changing 'chunk-cons' to use static methods directly instead of core fns.

This patch includes a commit to fix an issue in the chunked doseq, where seq was called on chunk-rest too early. When combinded with chunked concat this caused some laziness tests to fail.

chouser@n01se.net said: [file:d1Zsv2Ke4r3QR8eJe5afGb]: Add support for chunked seqs to 'for'

chouser@n01se.net said: (In [[r:dbe1710652618c842e513760e985c2219d71926b]]) delay seq on chunk-rest in doseq

doseq was calling seq on chunk-rest too early. When combinded with chunked
concat this caused some laziness tests to fail. Refs #1

Branch: master

chouser@n01se.net said: (In [[r:4af9fcf218c04db9b38fb4ce35591f1ff17a4f15]]) Add chunked seq support to concat

concat is defined early, so I moved the the chunk fns up which required
changing 'chunk-cons' to use static methods directly instead of core fns.
Refs #1

Branch: master

chouser@n01se.net said: (In [[r:14316ae2110a779ffc8ac9c3da3f1c41852c4289]]) Add support for chunked seqs to 'for'. Refs #1

Branch: master