Clojure

make print-table org mode compatible

Details

  • Type: Enhancement Enhancement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: Release 1.5
  • Component/s: None
  • Labels:
    None
  • Patch:
    Code
  • Approval:
    Ok

Activity

Hide
Andy Fingerhut added a comment -

Patch clj-1009-print-table-org-mode-patch2.txt dated June 8, 2012 is the same as Stuart Halloway's print-table-org-mode.txt of the same date, except a couple of tests have been added. His code changes look correct to me.

Show
Andy Fingerhut added a comment - Patch clj-1009-print-table-org-mode-patch2.txt dated June 8, 2012 is the same as Stuart Halloway's print-table-org-mode.txt of the same date, except a couple of tests have been added. His code changes look correct to me.
Andy Fingerhut made changes -
Field Original Value New Value
Attachment clj-1009-print-table-org-mode-patch2.txt [ 11303 ]
Andy Fingerhut made changes -
Attachment clj-1009-print-table-org-mode-patch2.txt [ 11304 ]
Andy Fingerhut made changes -
Attachment clj-1009-print-table-org-mode-patch2.txt [ 11304 ]
Andy Fingerhut made changes -
Comment [ Patch clj-1009-print-table-org-mode-patch2.txt dated June 8, 2012 is the same as Stuart Halloway's print-table-org-mode.txt of the same date, except a couple of tests have been added. His code changes look correct to me. ]
Hide
Aaron Bedra added a comment - - edited

This is not quite correct. the header separator in org-mode is

|--+--+--|
not
+--+--+

Show
Aaron Bedra added a comment - - edited This is not quite correct. the header separator in org-mode is
|--+--+--|
not
+--+--+
Aaron Bedra made changes -
Approval Vetted [ 10003 ] Incomplete [ 10006 ]
Hide
Andy Fingerhut added a comment -

clj-1009-print-table-org-mode-patch3.txt dated Aug 15, 2012 is same as the previous -patch2.txt version of Jun 8, 2012 (now deleted as obsolete), except it corrects the header separator as identified by Aaron Bedra.

Show
Andy Fingerhut added a comment - clj-1009-print-table-org-mode-patch3.txt dated Aug 15, 2012 is same as the previous -patch2.txt version of Jun 8, 2012 (now deleted as obsolete), except it corrects the header separator as identified by Aaron Bedra.
Andy Fingerhut made changes -
Hide
Andy Fingerhut added a comment -

Presumptuously changing approval from Incomplete back to Vetted, as it was before Aaron Bedra described a problem with the patch, and I updated the patch to address his comment. Feel free to apply the smackdown if necessary.

Show
Andy Fingerhut added a comment - Presumptuously changing approval from Incomplete back to Vetted, as it was before Aaron Bedra described a problem with the patch, and I updated the patch to address his comment. Feel free to apply the smackdown if necessary.
Andy Fingerhut made changes -
Approval Incomplete [ 10006 ] Vetted [ 10003 ]
Andy Fingerhut made changes -
Attachment clj-1009-print-table-org-mode-patch2.txt [ 11303 ]
Aaron Bedra made changes -
Approval Vetted [ 10003 ] Screened [ 10004 ]
Hide
Aaron Bedra added a comment -

Looks ok now. Three cheers for org-mode awesomeness!!!

Show
Aaron Bedra added a comment - Looks ok now. Three cheers for org-mode awesomeness!!!
Rich Hickey made changes -
Approval Screened [ 10004 ] Ok [ 10007 ]
Stuart Halloway made changes -
Resolution Completed [ 1 ]
Status Open [ 1 ] Closed [ 6 ]

People

Vote (2)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: