Clojure

CLJ-940 breaks compilation of namespaces that don't have any public functions

Details

  • Type: Defect Defect
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Completed
  • Affects Version/s: Release 1.5
  • Fix Version/s: Release 1.5
  • Component/s: None
  • Labels:
    None
  • Patch:
    Code
  • Approval:
    Ok

Description

CLJ-940 that was recently committed to master break compilation of namespaces that don't have any public functions in them
(for example, like https://github.com/michaelklishin/monger/blob/master/src/clojure/monger/json.clj that only extends
a protocol).

This affects several of clojurewerkz.org projects that no longer can compile with 1.5.0-master-SNAPSHOT.

Activity

Hide
Michael Klishin added a comment -

To be more correct: it breaks compilation of namespaces that require/load such ns without any public functions.

Show
Michael Klishin added a comment - To be more correct: it breaks compilation of namespaces that require/load such ns without any public functions.
Hide
Michael Klishin added a comment -

An example project that reproduces the issue (see in the README):
https://github.com/michaelklishin/clj1062

Show
Michael Klishin added a comment - An example project that reproduces the issue (see in the README): https://github.com/michaelklishin/clj1062
Michael Klishin made changes -
Field Original Value New Value
Comment [ Another ns that suffers from the same issue: https://github.com/michaelklishin/monger/blob/master/src/clojure/monger/operators.clj

(this one it makes sense to (:use), unlike the one with just protocol extensions) ]
Stuart Sierra made changes -
Assignee Stuart Sierra [ stuart.sierra ]
Stuart Sierra made changes -
Patch Code [ 10001 ]
Approval Vetted [ 10003 ]
Attachment 0001-CLJ-1062-fix-require-1.patch [ 11484 ]
Rich Hickey made changes -
Fix Version/s Release 1.5 [ 10150 ]
Stuart Halloway made changes -
Approval Vetted [ 10003 ] Screened [ 10004 ]
Stuart Sierra made changes -
Waiting On richhickey
Rich Hickey made changes -
Approval Screened [ 10004 ] Ok [ 10007 ]
Hide
Stuart Sierra added a comment -

Patch applied.

Show
Stuart Sierra added a comment - Patch applied.
Stuart Sierra made changes -
Resolution Completed [ 1 ]
Waiting On richhickey
Status Open [ 1 ] Resolved [ 5 ]
Stuart Halloway made changes -
Status Resolved [ 5 ] Closed [ 6 ]

People

Vote (0)
Watch (4)

Dates

  • Created:
    Updated:
    Resolved: