[#CLJ-1067] Fix error message inconsistencies in Symbol and Keyword - Clojure JIRA

Details

Type: Enhancement
Status: Closed
Priority: Trivial
Resolution: Declined
Affects Version/s: None
Fix Version/s: None
Component/s: None
Labels:
None

Approval:
Not Approved

Description

1. There are some ugly and unnecessary – but harmless – inconsistencies between Symbol and Keyword:

(.run 'foo);    => ArityException Wrong number of args (0) passed to: Symbol  clojure.lang.AFn.throwArity (AFn.java:437)
(.run :foo);    => UnsupportedOperationException   clojure.lang.Keyword.run (Keyword.java:97)
(.call 'foo);   => ArityException Wrong number of args (0) passed to: Symbol  clojure.lang.AFn.throwArity (AFn.java:437)
(.call :foo);   => IllegalArgumentException Wrong number of args passed to keyword: :foo  clojure.lang.Keyword.throwArity (Keyword.java:88)
(.invoke 'foo); => ArityException Wrong number of args (0) passed to: Symbol  clojure.lang.AFn.throwArity (AFn.java:437)
(.invoke :foo); => IllegalArgumentException Wrong number of args passed to keyword: :foo  clojure.lang.Keyword.throwArity (Keyword.java:88)

2. Keyword.java contains a lot of code that has already been factored out to AFn.java.

I propose that Keyword is modified to extend AFn to resolve the above issues.

More Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

Make-Keyword-extend-AFn-just-like-Symbol.patch

14/Sep/12 11:40 AM

6 kB

Christoffer Sawicki

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Stuart Halloway added a comment - 17/Sep/12 7:03 AM

At first glance, it appears that there could be some code sharing here. But the attached patch changes the semantics of run, which is a non-starter.

Show

Stuart Halloway added a comment - 17/Sep/12 7:03 AM At first glance, it appears that there could be some code sharing here. But the attached patch changes the semantics of run, which is a non-starter.

Hide

Permalink

Christoffer Sawicki added a comment - 17/Sep/12 7:19 AM

The only thing that changes is the type of thrown exception.

Current call tree:

Keyword.run() -> throw new UnsupportedOperationException()

Call tree with patch applied:

Keyword.run() -> AFn.run() -> AFn.invoke() -> AFn.throwArity(0) -> throw new ArityException(...)

(I.e. Keyword.run() always throws an exception, with and without my patch.)

Show

Christoffer Sawicki added a comment - 17/Sep/12 7:19 AM The only thing that changes is the type of thrown exception. Current call tree: Keyword.run() -> throw new UnsupportedOperationException() Call tree with patch applied: Keyword.run() -> AFn.run() -> AFn.invoke() -> AFn.throwArity(0) -> throw new ArityException(...) (I.e. Keyword.run() always throws an exception, with and without my patch.)

People

Assignee:

Unassigned

Reporter:

Christoffer Sawicki

Vote (0)

Watch (1)

Dates

Created:

14/Sep/12 11:38 AM

Updated:

01/Mar/13 12:47 PM

Resolved:

17/Sep/12 7:03 AM