[#CLJ-1083] Incorrect ArityException message for function names containing -> - Clojure JIRA

Details

Type: Defect
Status: Open
Priority: Minor
Resolution: Unresolved
Affects Version/s: Release 1.2, Release 1.3, Release 1.4, Release 1.5
Fix Version/s: Release 1.6
Component/s: None
Labels:
None

Patch:
Code
Approval:
Incomplete

Description

user=> (defn a->b [])
#'user/a->b
user=> (a->b 1)
ArityException Wrong number of args (1) passed to: user$a clojure.lang.AFn.throwArity (AFn.java:437)

Note that the reported function name in the stack trace is "user$a", where it should be "user$a->b" (or some mangled variant thereof?)

See discussion here: https://groups.google.com/d/msg/clojure/PVNoLclhhB0/_NWqyE0cPAUJ

More Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

better-throw-arity-messages.diff

26/Nov/12 10:27 AM

1 kB

Timothy Baldridge

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Timothy Baldridge added a comment - 26/Nov/12 10:27 AM

Fix for this defect.

Show

Timothy Baldridge added a comment - 26/Nov/12 10:27 AM Fix for this defect.

Hide

Permalink

Timothy Baldridge added a comment - 26/Nov/12 10:30 AM

The throwArity now attempts to locate and call clojure.main/demunge. If it finds the function it invokes it and uses the returned string in the error. Otherwise it just throws the actual class name. This results in the following behaviour:

user=> (defn a->b [])
#'user/a->b
user=> (a->b 32)
ArityException Wrong number of args (1) passed to: user/a->b clojure.lang.AFn.throwArity (AFn.java:449)
user=>

Show

Timothy Baldridge added a comment - 26/Nov/12 10:30 AM The throwArity now attempts to locate and call clojure.main/demunge. If it finds the function it invokes it and uses the returned string in the error. Otherwise it just throws the actual class name. This results in the following behaviour: user=> (defn a->b []) #'user/a->b user=> (a->b 32) ArityException Wrong number of args (1) passed to: user/a->b clojure.lang.AFn.throwArity (AFn.java:449) user=>

Hide

Permalink

Stuart Halloway added a comment - 24/May/13 11:35 AM

Timothy: Why the empty catch block? I don't see anything in the try block whose failure we would want to ignore.

Show

Stuart Halloway added a comment - 24/May/13 11:35 AM Timothy: Why the empty catch block? I don't see anything in the try block whose failure we would want to ignore.

People

Assignee:

Unassigned

Reporter:

Alex Nixon

Vote (2)

Watch (1)

Dates

Created:

09/Oct/12 11:18 AM

Updated:

Yesterday 11:35 AM