Clojure

(object-array [1]) is ~3x slower than (object-array (rseq [1]))

Details

  • Type: Defect Defect
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Completed
  • Affects Version/s: Release 1.4
  • Fix Version/s: Release 1.5
  • Component/s: None
  • Labels:
  • Patch:
    Code and Test
  • Approval:
    Ok

Description

{{user=> (time (dotimes [_ 10000000] (object-array [1])))
"Elapsed time: 1178.116257 msecs"
nil
user=> (time (dotimes [_ 10000000] (object-array (rseq [1]))))
"Elapsed time: 422.42248 msecs"
nil}}

This appears to be because PersistentVector$ChunkedSeq does not implement Counted, so RT.count is iterating the ChunkedSeq to get its count.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Paul Stadig added a comment -

I don't believe this is Major priority, but I cannot edit the ticket after having created it.

Show
Paul Stadig added a comment - I don't believe this is Major priority, but I cannot edit the ticket after having created it.
Hide
Permalink
Tassilo Horn added a comment -

This patch makes PersistentVector$ChunkedSeq implement Counted.

Performance before:

(let [v (vec (range 10000))
      vs (seq v)]
  (time (dotimes [_ 10000]
          (count v)))
  (time (dotimes [_ 10000]
          (count vs))))
;"Elapsed time: 0.862259 msecs"
;"Elapsed time: 7228.72486 msecs"

Performance after (with the patch):

(let [v (vec (range 10000))
      vs (seq v)]
  (time (dotimes [_ 10000]
          (count v)))
  (time (dotimes [_ 10000]
          (count vs))))
;"Elapsed time: 0.967301 msecs"
;"Elapsed time: 0.99391 msecs"

Also with Paul's test case.

Before:

(time (dotimes [_ 10000000] (object-array [1])))
;"Elapsed time: 1668.346997 msecs"
(time (dotimes [_ 10000000] (object-array (rseq [1]))))
;"Elapsed time: 662.820591 msecs"

After:

(time (dotimes [_ 10000000] (object-array [1])))
;"Elapsed time: 757.084577 msecs"
(time (dotimes [_ 10000000] (object-array (rseq [1]))))
;"Elapsed time: 680.602921 msecs"
Show
Tassilo Horn added a comment - This patch makes PersistentVector$ChunkedSeq implement Counted. Performance before: 
(let [v (vec (range 10000))
      vs (seq v)]
  (time (dotimes [_ 10000]
          (count v)))
  (time (dotimes [_ 10000]
          (count vs))))
;"Elapsed time: 0.862259 msecs"
;"Elapsed time: 7228.72486 msecs"
Performance after (with the patch): 
(let [v (vec (range 10000))
      vs (seq v)]
  (time (dotimes [_ 10000]
          (count v)))
  (time (dotimes [_ 10000]
          (count vs))))
;"Elapsed time: 0.967301 msecs"
;"Elapsed time: 0.99391 msecs"
Also with Paul's test case. Before: 
(time (dotimes [_ 10000000] (object-array [1])))
;"Elapsed time: 1668.346997 msecs"
(time (dotimes [_ 10000000] (object-array (rseq [1]))))
;"Elapsed time: 662.820591 msecs"
After: 
(time (dotimes [_ 10000000] (object-array [1])))
;"Elapsed time: 757.084577 msecs"
(time (dotimes [_ 10000000] (object-array (rseq [1]))))
;"Elapsed time: 680.602921 msecs"
Tassilo Horn made changes -
Field Original Value New Value
Attachment 0001-Make-PersistentVector-ChunkedSeq-implement-Counted.patch [ 11551 ]
Attachment 0001-Make-PersistentVector-ChunkedSeq-implement-Counted.patch [ 11550 ]
Tassilo Horn made changes -
Attachment 0001-Make-PersistentVector-ChunkedSeq-implement-Counted.patch [ 11550 ]
Tassilo Horn made changes -
Labels patch, test
Tassilo Horn made changes -
Patch Code [ 10001 ]
Labels patch, test patch,
Tassilo Horn made changes -
Affects Version/s Release 1.4 [ 10040 ]
Fix Version/s Release 1.5 [ 10150 ]
Andy Fingerhut made changes -
Priority Major [ 3 ] Minor [ 4 ]
Hide
Permalink
Stuart Halloway added a comment -

Two patches to be applied together, the 10/19 patch adds tests and updates to latest test.generative.

Show
Stuart Halloway added a comment - Two patches to be applied together, the 10/19 patch adds tests and updates to latest test.generative.
Stuart Halloway made changes -
Patch Code [ 10001 ] Code and Test [ 10002 ]
Approval Screened [ 10004 ]
Attachment CLJ-1084-tests.patch [ 11580 ]
Rich Hickey made changes -
Approval Screened [ 10004 ] Ok [ 10007 ]
Stuart Halloway made changes -
Resolution Completed [ 1 ]
Status Open [ 1 ] Closed [ 6 ]

People

Vote (1)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4#649-r158309) | Report a problem
Powered by a free Atlassian JIRA open source license for Clojure. Try JIRA - bug tracking software for your team.