Details
-
Type:
Defect
-
Status:
Closed
-
Priority:
Minor
-
Resolution: Declined
-
Affects Version/s: None
-
Fix Version/s: None
-
Component/s: None
-
Labels:None
Description
According to the interface http://docs.oracle.com/javase/6/docs/api/java/io/InputStream.html#read()
InputStream.read() family of methods return -1 when the end of stream is reached.
do-copy methods currently use a test: (pos? size) to determine whether eos is reached. This mostly works, but the specification is pretty clear in that InputStream implementations are allowed to return reads of zero bytes before returning more bytes.
##EDIT changed title of ticket from "clojure.java.io/copy should test for -1 instead of 0 for end of stream"
Attachments
Activity
Herwig Hochleitner
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Attachment | 0001-CLJ-1089-clojure.java.io-do-copy-methods-determine-e.patch [ 11599 ] |
Herwig Hochleitner
made changes -
| Description |
According to the interface http://docs.oracle.com/javase/6/docs/api/java/io/InputStream.html#read()
InputStream.read() family of methods return -1 when the end of stream is reached. do-copy methods currently use a test: (pos? size) to determine whether eos is reached. This mostly works, but the specification is pretty clear in that InputStream implementations are allowed to return reads of zero bytes before returning more bytes. |
According to the interface http://docs.oracle.com/javase/6/docs/api/java/io/InputStream.html#read()
InputStream.read() family of methods return -1 when the end of stream is reached. do-copy methods currently use a test: (pos? size) to determine whether eos is reached. This mostly works, but the specification is pretty clear in that InputStream implementations are allowed to return reads of zero bytes before returning more bytes. ##EDIT changed title of ticket from "clojure.java.io/copy should test for -1 instead of 0 for end of stream" |
| Summary | clojure.java.io/copy should test for -1 instead of 0 for end of stream | clojure.java.io/copy interprets read count of 0 as eos |
Herwig Hochleitner
made changes -
| Resolution | Declined [ 2 ] | |
| Status | Open [ 1 ] | Closed [ 6 ] |