[#CLJ-1093] Empty record literals gets incorrectly evaluated to array-maps - Clojure JIRA

Details

Type: Defect
Status: Reopened
Priority: Major
Resolution: Unresolved
Affects Version/s: Release 1.4, Release 1.5
Fix Version/s: None
Component/s: None
Labels:
None

Patch:
Code and Test

Description

before patch:
user=> (defrecord a [b])
user.a
user=> #user.a{}
{}

after patch:
user=> (defrecord a [b])
user.a
user=> #user.a{}
#user.a{:b nil}

More Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

001-fix-empty-record-literal.patch

24/Oct/12 9:19 AM

2 kB

Nicola Mometto
clj-1093-fix-empty-record-literal-patch-v2.txt

13/Mar/13 2:04 PM

2 kB

Andy Fingerhut

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Timothy Baldridge added a comment - 27/Nov/12 11:41 AM

Unable to reproduce this bug on latest version of master. Most likely fixed by some of the recent changes to data literal readers.

Marking Not-Approved.

Show

Timothy Baldridge added a comment - 27/Nov/12 11:41 AM Unable to reproduce this bug on latest version of master. Most likely fixed by some of the recent changes to data literal readers. Marking Not-Approved.

Hide

Permalink

Timothy Baldridge added a comment - 27/Nov/12 11:41 AM

Could not reproduce in master.

Show

Timothy Baldridge added a comment - 27/Nov/12 11:41 AM Could not reproduce in master.

Hide

Permalink

Nicola Mometto added a comment - 01/Mar/13 1:23 PM

I just checked, and the problem still exists for records with no arguments:

Clojure 1.6.0-master-SNAPSHOT
user=> (defrecord a [])
user.a
user=> #user.a[]
{}

Admittedly it's an edge case and I see little usage for no-arguments records, but I think it should be addressed aswell since the current behaviour is not what one would expect

Show

Nicola Mometto added a comment - 01/Mar/13 1:23 PM I just checked, and the problem still exists for records with no arguments: Clojure 1.6.0-master-SNAPSHOT user=> (defrecord a []) user.a user=> #user.a[] {} Admittedly it's an edge case and I see little usage for no-arguments records, but I think it should be addressed aswell since the current behaviour is not what one would expect

Hide

Permalink

Herwig Hochleitner added a comment - 02/Mar/13 8:14 AM

Got the following REPL interaction:

% java -jar ~/.m2/repository/org/clojure/clojure/1.5.0/clojure-1.5.0.jar
user=> (defrecord a [])
user.a
user=> (a.)
#user.a{}
user=> #user.a{}
{}
#user.a[]
{}

This should be reopened or declined for another reason than reproducability.

Show

Herwig Hochleitner added a comment - 02/Mar/13 8:14 AM Got the following REPL interaction:

% java -jar ~/.m2/repository/org/clojure/clojure/1.5.0/clojure-1.5.0.jar
user=> (defrecord a [])
user.a
user=> (a.)
#user.a{}
user=> #user.a{}
{}
#user.a[]
{}

This should be reopened or declined for another reason than reproducability.

Hide

Permalink

Nicola Mometto added a comment - 10/Mar/13 2:18 PM

I'm reopening this since the bug is still there.

Show

Nicola Mometto added a comment - 10/Mar/13 2:18 PM I'm reopening this since the bug is still there.

Hide

Permalink

Andy Fingerhut added a comment - 13/Mar/13 2:04 PM

Patch clj-1093-fix-empty-record-literal-patch-v2.txt dated Mar 13, 2013 is identical to Bronsa's patch 001-fix-empty-record-literal.patch dated Oct 24, 2012, except that it applies cleanly to latest master. I'm not sure why the older patch doesn't but git doesn't like something about it.

Show

Andy Fingerhut added a comment - 13/Mar/13 2:04 PM Patch clj-1093-fix-empty-record-literal-patch-v2.txt dated Mar 13, 2013 is identical to Bronsa's patch 001-fix-empty-record-literal.patch dated Oct 24, 2012, except that it applies cleanly to latest master. I'm not sure why the older patch doesn't but git doesn't like something about it.

People

Assignee:

Timothy Baldridge

Reporter:

Nicola Mometto

Vote (2)

Watch (1)

Dates

Created:

24/Oct/12 9:13 AM

Updated:

13/Mar/13 2:04 PM