Clojure

Make destructuring emit direct keyword lookups

Details

  • Type: Enhancement Enhancement
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: Release 1.4
  • Fix Version/s: None
  • Component/s: None
  • Labels:
  • Patch:
    Code

Description

Currently associative destructuring emits calls to get. The attached patch modify desctruture to emit direct keyword lookups when possible.

Approved here https://groups.google.com/d/msg/clojure-dev/MaYcHQck8VA/nauMus4mzPgJ

Activity

Christophe Grand made changes -
Field Original Value New Value
Assignee Christophe Grand [ cgrand ]
Alex Miller made changes -
Labels performance
Summary Make destrucring emit direct keyword lookups Make destructuring emit direct keyword lookups
Hide
Christophe Grand added a comment -

Rethinking about this patch now, it may be too specific: get's inline expansion should be modified when the key is a literal keyword.

Show
Christophe Grand added a comment - Rethinking about this patch now, it may be too specific: get's inline expansion should be modified when the key is a literal keyword.
Hide
Christophe Grand added a comment - - edited

More generic patch (inline-get-keyword.diff): all get calls with literal keywords as keys are inlined to direct keyword lookup.

Show
Christophe Grand added a comment - - edited More generic patch (inline-get-keyword.diff): all get calls with literal keywords as keys are inlined to direct keyword lookup.
Christophe Grand made changes -
Attachment inline-get-keyword.diff [ 12232 ]

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated: