Details
-
Type:
Defect
-
Status:
Open
-
Priority:
Minor
-
Resolution: Unresolved
-
Affects Version/s: Release 1.4
-
Fix Version/s: Release 1.6
-
Component/s: None
-
Labels:None
-
Approval:Vetted
Description
Using clojure.walk functions fails surprisingly for data containing records defined with defrecord:
user=> (defrecord Foo [x])
user.Foo
user=> (def f (Foo. :x))
#'user/f
user=> (use 'clojure.walk)
nil
user=> (postwalk identity {:foo f})
UnsupportedOperationException Can't create empty: user.Foo user.Foo (NO_SOURCE_FILE:1)
This seems to be because clojure.walk/walk guards a call to (empty form) with a (coll? form) check. The check succeeds because records implement IPersistentCollection, but (empty form) throws an exception. This looks to me like a bug in clojure.walk (it should check records separately and either treat them as atomic or implement a way of walking through them) but perhaps it is a sign of some unclarity in the contract of collections.
Activity
| Field | Original Value | New Value |
|---|---|---|
| Approval | Vetted [ 10003 ] | |
| Fix Version/s | Approved Backlog [ 10034 ] |
| Fix Version/s | Approved Backlog [ 10034 ] | |
| Fix Version/s | Release 1.6 [ 10157 ] |
maybe clojure should follow clojurescript's footsteps and move empty out of IPersistentCollection and create an
interface IEmptyableCollection extends IPersistentCollection { IEmptyableCollection empty(); }