Clojure

Oracle Java 5 fails to run tests when building Clojure

Details

  • Type: Defect Defect
  • Status: Closed Closed
  • Priority: Trivial Trivial
  • Resolution: Completed
  • Affects Version/s: Release 1.5
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None
  • Environment:
    Oracle Java 1.5.0_22, at least
  • Patch:
    Code and Test

Description

This is due to the way that reducers.clj currently handles the ForkJoin library.

Activity

Hide
Rich Hickey added a comment -

This is the wrong approach to this problem. A better approach is to make reducers work even if no fj support is present by simply defining fold as sequential reduce in that case.

Show
Rich Hickey added a comment - This is the wrong approach to this problem. A better approach is to make reducers work even if no fj support is present by simply defining fold as sequential reduce in that case.
Hide
Timothy Baldridge added a comment -

IMO, more tests are always good. Vetted.

Show
Timothy Baldridge added a comment - IMO, more tests are always good. Vetted.
Hide
Andy Fingerhut added a comment -

Updated patch with proper name and email address.

Show
Andy Fingerhut added a comment - Updated patch with proper name and email address.
Hide
Andy Fingerhut added a comment -

Patch patch-enable-java-5-to-pass-tests-v1.txt dated Nov 19 2012 enables at least Oracle Java 1.5.0_22 to build and pass all tests in latest master.

No, tt doesn't implement a ForkJoin library. It simply declares some Clojure fj functions to throw an exception if they are called. In today's Clojure tests they never are.

Show
Andy Fingerhut added a comment - Patch patch-enable-java-5-to-pass-tests-v1.txt dated Nov 19 2012 enables at least Oracle Java 1.5.0_22 to build and pass all tests in latest master. No, tt doesn't implement a ForkJoin library. It simply declares some Clojure fj functions to throw an exception if they are called. In today's Clojure tests they never are.

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: