[#CLJ-1109] Oracle Java 5 fails to run tests when building Clojure - Clojure JIRA

Details

Type: Defect
Status: Closed
Priority: Trivial
Resolution: Completed
Affects Version/s: Release 1.5
Fix Version/s: None
Component/s: None
Labels:
None
Environment:
Oracle Java 1.5.0_22, at least

Patch:
Code and Test
Approval:
Not Approved

Description

This is due to the way that reducers.clj currently handles the ForkJoin library.

More Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

patch-enable-java-5-to-pass-tests-v1.txt

20/Nov/12 3:45 PM

3 kB

Andy Fingerhut

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Andy Fingerhut added a comment - 19/Nov/12 3:50 PM

Patch patch-enable-java-5-to-pass-tests-v1.txt dated Nov 19 2012 enables at least Oracle Java 1.5.0_22 to build and pass all tests in latest master.

No, tt doesn't implement a ForkJoin library. It simply declares some Clojure fj functions to throw an exception if they are called. In today's Clojure tests they never are.

Show

Andy Fingerhut added a comment - 19/Nov/12 3:50 PM Patch patch-enable-java-5-to-pass-tests-v1.txt dated Nov 19 2012 enables at least Oracle Java 1.5.0_22 to build and pass all tests in latest master. No, tt doesn't implement a ForkJoin library. It simply declares some Clojure fj functions to throw an exception if they are called. In today's Clojure tests they never are.

Hide

Permalink

Andy Fingerhut added a comment - 20/Nov/12 3:45 PM

Updated patch with proper name and email address.

Show

Andy Fingerhut added a comment - 20/Nov/12 3:45 PM Updated patch with proper name and email address.

Hide

Permalink

Timothy Baldridge added a comment - 30/Nov/12 3:05 PM

IMO, more tests are always good. Vetted.

Show

Timothy Baldridge added a comment - 30/Nov/12 3:05 PM IMO, more tests are always good. Vetted.

Hide

Permalink

Rich Hickey added a comment - 15/Dec/12 7:33 AM

This is the wrong approach to this problem. A better approach is to make reducers work even if no fj support is present by simply defining fold as sequential reduce in that case.

Show

Rich Hickey added a comment - 15/Dec/12 7:33 AM This is the wrong approach to this problem. A better approach is to make reducers work even if no fj support is present by simply defining fold as sequential reduce in that case.

People

Assignee:

Unassigned

Reporter:

Andy Fingerhut

Vote (0)

Watch (2)

Dates

Created:

19/Nov/12 3:48 PM

Updated:

15/Dec/12 7:33 AM

Resolved:

15/Dec/12 7:33 AM