Details
-
Type:
Enhancement
-
Status:
Open
-
Priority:
Major
-
Resolution: Unresolved
-
Affects Version/s: None
-
Fix Version/s: None
-
Component/s: None
-
Labels:
-
Patch:Code
Description
Protocol, interface method declarations don't allow for varags. Currently, for example
(defprotocol FooBar
(foo [this & more]))
compiles just fine, and & is interpreted as a usual argument that happens to be
named & without special meaning. But clearly, the user wanted to specify a
varags parameter here. The same applies to definterface.
Similarly, providing method implementations via defrecord, deftype, and reify
don't allow for varags (but dynamic extensions via extend do).
So this patch makes defprotocol and definterface throw an
IllegalArgumentException if a user tries to use varargs in method signatures.
Similarly, defrecord, deftype, and reify throw an IllegalArgumentException if
any method implementation arglist contains a varargs argument.
This patch is a cut-down variant of my patch to http://dev.clojure.org/jira/browse/CLJ-1024
which has been reverted shortly before Clojure 1.5 was released. The CLJ-1024 patch
was the same as this one, but it has also forbidden destructuring in defprotocol and
definterface. This was a bit too much, because although destructuring has no
semantic meaning with method declarations, it still can serve a documentation purpose.
This has been discussed on the list: https://groups.google.com/d/topic/clojure-dev/qjkW-cv8nog/discussion
Attachments
Activity
Tassilo Horn
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Description |
Protocol, interface method declarations don't allow for varags. Currently, for example
{noformat} (defprotocol FooBar (foo [this & more])) {noformat} compiles just fine, and {{&}} is interpreted as a usual argument that happens to be named {{&}} without special meaning. But clearly, the user wanted to specify a varags parameter here. The same applies to definterface. Similarly, providing method implementations via defrecord, deftype, and reify don't allow for varags (but dynamic extensions via extend do). So this patch makes defprotocol and definterface throw an IllegalArgumentException if a user tries to use varargs in method signatures. Similarly, defrecord, deftype, and reify throw an IllegalArgumentException if any method implementation arglist contains a varargs argument. This patch is a cut-down variant of my patch to http://dev.clojure.org/jira/browse/CLJ-1024 which has been reverted shortly before Clojure 1.5 was released. The was the same as this one, but it has also forbidden destructuring in {{defprotocol}} and {{definterface}}. This was a bit too much, because although destructuring has no semantic meaning with method declarations, it still can serve an documentation purpose. This has been discussed on the list: https://groups.google.com/d/topic/clojure-dev/qjkW-cv8nog/discussion |
Protocol, interface method declarations don't allow for varags. Currently, for example
{noformat} (defprotocol FooBar (foo [this & more])) {noformat} compiles just fine, and {{&}} is interpreted as a usual argument that happens to be named {{&}} without special meaning. But clearly, the user wanted to specify a varags parameter here. The same applies to {{definterface}}. Similarly, providing method implementations via defrecord, deftype, and reify don't allow for varags (but dynamic extensions via extend do). So this patch makes {{defprotocol}} and {{definterface}} throw an {{IllegalArgumentException}} if a user tries to use varargs in method signatures. Similarly, {{defrecord}}, {{deftype}}, and {{reify}} throw an {{IllegalArgumentException}} if any method implementation arglist contains a varargs argument. This patch is a cut-down variant of my patch to http://dev.clojure.org/jira/browse/CLJ-1024 which has been reverted shortly before Clojure 1.5 was released. The was the same as this one, but it has also forbidden destructuring in {{defprotocol}} and {{definterface}}. This was a bit too much, because although destructuring has no semantic meaning with method declarations, it still can serve a documentation purpose. This has been discussed on the list: https://groups.google.com/d/topic/clojure-dev/qjkW-cv8nog/discussion |
Tassilo Horn
made changes -
| Description |
Protocol, interface method declarations don't allow for varags. Currently, for example
{noformat} (defprotocol FooBar (foo [this & more])) {noformat} compiles just fine, and {{&}} is interpreted as a usual argument that happens to be named {{&}} without special meaning. But clearly, the user wanted to specify a varags parameter here. The same applies to {{definterface}}. Similarly, providing method implementations via defrecord, deftype, and reify don't allow for varags (but dynamic extensions via extend do). So this patch makes {{defprotocol}} and {{definterface}} throw an {{IllegalArgumentException}} if a user tries to use varargs in method signatures. Similarly, {{defrecord}}, {{deftype}}, and {{reify}} throw an {{IllegalArgumentException}} if any method implementation arglist contains a varargs argument. This patch is a cut-down variant of my patch to http://dev.clojure.org/jira/browse/CLJ-1024 which has been reverted shortly before Clojure 1.5 was released. The was the same as this one, but it has also forbidden destructuring in {{defprotocol}} and {{definterface}}. This was a bit too much, because although destructuring has no semantic meaning with method declarations, it still can serve a documentation purpose. This has been discussed on the list: https://groups.google.com/d/topic/clojure-dev/qjkW-cv8nog/discussion |
Protocol, interface method declarations don't allow for varags. Currently, for example
{noformat} (defprotocol FooBar (foo [this & more])) {noformat} compiles just fine, and {{&}} is interpreted as a usual argument that happens to be named {{&}} without special meaning. But clearly, the user wanted to specify a varags parameter here. The same applies to {{definterface}}. Similarly, providing method implementations via {{defrecord}}, {{deftype}}, and {{reify}} don't allow for varags (but dynamic extensions via {{extend}} do). So this patch makes {{defprotocol}} and {{definterface}} throw an {{IllegalArgumentException}} if a user tries to use varargs in method signatures. Similarly, {{defrecord}}, {{deftype}}, and {{reify}} throw an {{IllegalArgumentException}} if any method implementation arglist contains a varargs argument. This patch is a cut-down variant of my patch to http://dev.clojure.org/jira/browse/CLJ-1024 which has been reverted shortly before Clojure 1.5 was released. The was the same as this one, but it has also forbidden destructuring in {{defprotocol}} and {{definterface}}. This was a bit too much, because although destructuring has no semantic meaning with method declarations, it still can serve a documentation purpose. This has been discussed on the list: https://groups.google.com/d/topic/clojure-dev/qjkW-cv8nog/discussion |
Stuart Halloway
made changes -
| Approval | Incomplete [ 10006 ] |
Tassilo Horn
made changes -
| Attachment | 0001-Protocol-interface-method-declarations-don-t-allow-f.patch [ 11933 ] |
Tassilo Horn
made changes -
| Attachment | 0001-Protocol-interface-method-declarations-don-t-allow-f.patch [ 11860 ] |
Andy Fingerhut
made changes -
| Approval | Incomplete [ 10006 ] |
I think that this patch would be much more helpful to users if it reported the problem form (both name and params).
(And I wonder if we should be using ex-info for all errors going forward.)