clojure.repl/source fails when read-eval bound to :unknown

Description

clojure.repl/source is broken in Clojure 1.5.1 when *read-eval* is bound to :unknown, since source-fn reads without binding.

user> (alter-var-root #'*read-eval* (constantly :unknown))
:unknown
user> (source drop-last)
RuntimeException Reading disallowed - *read-eval* bound to :unknown  clojure.lang.Util.runtimeException (Util.java:219)

Approach: Throw explicit error stating the cause in this case.

Patch: clj-1176-source-read-eval-3.patch

Screened by: Stuart Sierra

Environment

None

Attachments

clj-1176-source-read-eval-3.patch

14 Jan, 2014

clj-1176-source-read-eval-2.patch

30 Dec, 2013

0001-CLJ-1176-Bind-read-eval-true-in-clojure.repl-source-.patch

06 Mar, 2013

Activity

Stuart Sierra

January 17, 2014 at 3:44 PM

Screened ✔

Alex Miller

January 14, 2014 at 3:01 PM

Stuart - totally good catch. Things did not work how I thought they worked! I have updated the patch.

Stuart Sierra

January 10, 2014 at 10:44 PM

Changed my mind: resetting to 'incomplete'.

This patch doesn't fix the situation in the original report. To improve the error message, it should handle the :unknown case.

If read-eval is false, then source still works as long as the source form doesn't contain #=

Stuart Sierra

January 10, 2014 at 10:37 PM

Screened OK.

Note that this only changes the error message when read-eval is bound to false, not when it is bound to :unknown.

Alex Miller

December 30, 2013 at 4:47 AM

Updated with new patch that detects and throws an error if calling source with read-eval is false.

Resize work item view side panel

Completed

Details

Assignee

Unassigned

Reporter

Tim McCormack [personal]

Labels

repl

Approval

Patch

Code and Test

Priority

Minor

Affects versions

Release 1.5

Fix versions

Release 1.6

Created March 6, 2013 at 9:26 PM

Updated January 31, 2014 at 6:19 PM

Resolved January 31, 2014 at 6:19 PM

clojure.repl/source fails when *read-eval* bound to :unknown

Description

Environment

Attachments

Activity

Details

Assignee

Reporter

Labels

Approval

Patch

Priority

Affects versions

Fix versions

clojure.repl/source fails when read-eval bound to :unknown