[#CLJ-1181] clojure.pprint/code-dispatch breaks on certain types of anonymous functions - Clojure JIRA

Details

Type: Defect
Status: Open
Priority: Major
Resolution: Unresolved
Affects Version/s: Release 1.5
Fix Version/s: None
Component/s: None
Labels:
None

Description

(with-out-str 
  (with-pprint-dispatch code-dispatch 
                        (pp/pprint (read-string "(fn* [x] x)"))))

breaks because the format string here: https://github.com/clojure/clojure/blob/master/src/clj/clojure/pprint/dispatch.clj#L378 expects a sequence. In the case of (fn* [x] x) it is passed a symbol.

Activity

Hide

Permalink

Jean Niklas L'orange added a comment - 18/Mar/13 5:40 PM

I think the main "issue" here resides within the undocumented functionality of fn*. (fn* [x] x) is a semantically working function, but (fn [x] x) expands into (fn* ([x] x)). Anonymous function literals expand into (fn* [gensyms] (...)), and as such, it also accepts expressions like (fn* [x] x). Should pprint pretty print expressions which has used fn* directly, or should it "just" ignore it?

Show

Jean Niklas L'orange added a comment - 18/Mar/13 5:40 PM I think the main "issue" here resides within the undocumented functionality of fn*. (fn* [x] x) is a semantically working function, but (fn [x] x) expands into (fn* ([x] x)). Anonymous function literals expand into (fn* [gensyms] (...)), and as such, it also accepts expressions like (fn* [x] x). Should pprint pretty print expressions which has used fn* directly, or should it "just" ignore it?

People

Assignee:

Unassigned

Reporter:

Devin Walters

Vote (1)

Watch (2)

Dates

Created:

10/Mar/13 4:40 PM

Updated:

18/Mar/13 5:40 PM