Clojure

Typo in core.reducers

Details

  • Type: Defect Defect
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Declined
  • Affects Version/s: Release 1.5
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None

Description

As far as I can say, there is a typo in core.reducers (and therefore core.reducers/monoid is unusable in 1.5.1):

https://github.com/clojure/clojure/blob/master/src/clj/clojure/core/reducers.clj#L321

(fn m <-- this
    ([] (ctor))
    ([a b] (op a b))))

Should I submit a patch to fix this?

Activity

Hide
Dmitry Groshev added a comment -

Andy, I'll close it myself if you don't mind. I would done it earlier, but didn't have sufficient rights in JIRA.

Show
Dmitry Groshev added a comment - Andy, I'll close it myself if you don't mind. I would done it earlier, but didn't have sufficient rights in JIRA.
Hide
Andy Fingerhut added a comment -

Dmitry, do you think it is OK to close this ticket as declined, meaning no change will be made in response to it? I can do that for you, if you wish.

Show
Andy Fingerhut added a comment - Dmitry, do you think it is OK to close this ticket as declined, meaning no change will be made in response to it? I can do that for you, if you wish.
Hide
Dmitry Groshev added a comment -

I did, but as it turns out the error was somewhere else and I can't reproduce it within a "clean" environment. Sorry for this hasty ticket.

Show
Dmitry Groshev added a comment - I did, but as it turns out the error was somewhere else and I can't reproduce it within a "clean" environment. Sorry for this hasty ticket.
Hide
Ghadi Shayban added a comment -

I guess you didn't try to actually use the function to see if it is actually broken...

m is not a argument vector, those are below in the function clauses.

Show
Ghadi Shayban added a comment - I guess you didn't try to actually use the function to see if it is actually broken... m is not a argument vector, those are below in the function clauses.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: