Details
-
Type:
Defect
-
Status:
Closed
-
Priority:
Major
-
Resolution: Completed
-
Affects Version/s: Release 1.7
-
Fix Version/s: Release 1.8
-
Component/s: None
-
Patch:Code and Test
-
Approval:Ok
Description
set! can be used to set a public field on an instance with (set! (.field inst) val). This does not work inside a protocol function defined on a deftype with a mutable field for an instance of that type itself.
user=> (defprotocol p (f [_])) p user=> (deftype t [^:unsynchronized-mutable x] p (f [this] (set! (.x this) 1))) user.t user=> (f (t. 1)) ;; expect: 1 ClassCastException user.t cannot be cast to compile__stub.user.t user.t (NO_SOURCE_FILE:1
Cause: The type assigned in the bytecode at this point is the compile_stub type, not the expected class type.
Approach: Use getType(targetClass) instead of Type.getType(targetClass)
Patch: 0001-CLJ-1226-fix-set-of-instance-field-expression-that-r-v2.patch
Screened by: Fogus
This patch offers a better workaround for
CLJ-1075, making it possible to write(deftype foo [^:unsynchronized-mutable x] MutableX (set-x [this v] (try (set! (.x this) v)) v))
CLJ-1075, making it possible to write (deftype foo [^:unsynchronized-mutable x] MutableX (set-x [this v] (try (set! (.x this) v)) v))