set! of a deftype field using field-access syntax causes ClassCastException

Description

set! can be used to set a public field on an instance with (set! (.field inst) val). This does not work inside a protocol function defined on a deftype with a mutable field for an instance of that type itself.

Cause: The type assigned in the bytecode at this point is the compile_stub type, not the expected class type.

Approach: Use getType(targetClass) instead of Type.getType(targetClass)

Patch: 0001-CLJ-1226-fix-set-of-instance-field-expression-that-r-v2.patch
Screened by: Fogus

Environment

None

Attachments

0001-CLJ-1226-fix-set-of-instance-field-expression-that-r-v2.patch

25 Mar, 2015

0001-CLJ-1226-fix-set-of-instance-field-expression-that-r.patch

31 Aug, 2014

Activity

Rich Hickey

August 8, 2015 at 4:05 PM

Screeners - please make sure the patch has an Approach section that explains how and why the patch will fix the problem. Symptom is X and now after patch behavior is Y is not good enough.

Fogus

August 7, 2015 at 9:10 PM

Straight-forward fix and test.

Nicola Mometto

March 25, 2015 at 10:39 PM

Updated patch to apply to current master

Nicola Mometto

June 27, 2013 at 11:30 AM

This patch offers a better workaround for CLJ-1075, making it possible to write
(deftype foo [^:unsynchronized-mutable x] MutableX (set-x [this v] (try (set! (.x this) v)) v))

Resize work item view side panel

Completed

Details

Assignee

Unassigned

Reporter

Nicola Mometto

Labels

compilerdeftypeinterop

Approval

Patch

Code and Test

Priority

Major

Affects versions

Release 1.7

Fix versions

Release 1.8

Created June 27, 2013 at 1:21 AM

Updated October 13, 2015 at 3:37 AM

Resolved October 13, 2015 at 3:37 AM