Clojure

Remove (apparently) vestigial forward-defs of unquote and unquote-splicing

Details

  • Type: Enhancement Enhancement
  • Status: Closed Closed
  • Priority: Trivial Trivial
  • Resolution: Declined
  • Affects Version/s: Release 1.5
  • Fix Version/s: None
  • Component/s: None
  • Labels:
  • Patch:
    Code

Description

clojure/core.clj contains forward defs of unquote and unquote-splicing that seem no longer to be necessary. The pull request at https://github.com/clojure/clojure/pull/45 removes this dead code (also attaching a git diff file). Existing tests pass; no new test code necessary.

Activity

Hide
Alex Miller added a comment -

FYI for future reference, Clojure doesn't accept pull requests. Thanks for the report though!

Show
Alex Miller added a comment - FYI for future reference, Clojure doesn't accept pull requests. Thanks for the report though!
Hide
David Rupp added a comment -

I noticed. That's why I created the JIRA.

Show
David Rupp added a comment - I noticed. That's why I created the JIRA.
Hide
Andy Fingerhut added a comment -

David, I do not have any comment on whether this patch will be accepted or not based on the changes it makes, but patches do need to be in a particular format, including the author's name. See instructions for how to create a patch in this format here: http://dev.clojure.org/display/community/Developing+Patches

Show
Andy Fingerhut added a comment - David, I do not have any comment on whether this patch will be accepted or not based on the changes it makes, but patches do need to be in a particular format, including the author's name. See instructions for how to create a patch in this format here: http://dev.clojure.org/display/community/Developing+Patches
Hide
David Rupp added a comment -

Submitting properly-formatted patch.

Show
David Rupp added a comment - Submitting properly-formatted patch.
Hide
David Rupp added a comment - - edited

Replaced references to clojure.core/unquote and .../unquote-splicing,
which are unbound.

The UNQUOTE and UNQUOTE-SPLICING Symbols in LispReader don't really
refer to anything in clojure.core any longer. They're created and
elided by the reader when it encounters their respective (reader)
macro chars.

Show
David Rupp added a comment - - edited Replaced references to clojure.core/unquote and .../unquote-splicing, which are unbound. The UNQUOTE and UNQUOTE-SPLICING Symbols in LispReader don't really refer to anything in clojure.core any longer. They're created and elided by the reader when it encounters their respective (reader) macro chars.
Hide
Stuart Halloway added a comment -

The patch attached here is poorly-suited for screening. It does more than what it says, (e.g. deleting the def of META) without explaining why.

It also removes things that are commented out. Pretty clear that the BDFL likes having those things stick around.

Show
Stuart Halloway added a comment - The patch attached here is poorly-suited for screening. It does more than what it says, (e.g. deleting the def of META) without explaining why. It also removes things that are commented out. Pretty clear that the BDFL likes having those things stick around.
Hide
David Rupp added a comment -

META is not used anywhere. I will explain better next time.

Also, DEREF_BANG has been commented out since 2007 (commit 139ddd146f2a272b7ddda397f54b501ff499c643). Figured it was pretty safe to get rid of at this point. My bad.

Show
David Rupp added a comment - META is not used anywhere. I will explain better next time. Also, DEREF_BANG has been commented out since 2007 (commit 139ddd146f2a272b7ddda397f54b501ff499c643). Figured it was pretty safe to get rid of at this point. My bad.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: