Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Correct a few unit tests

Description

Several unit tests do not test what they appear to have been intended to test, because of missing is statements around (= expr1 expr2) expressions, or because of use of (is (thrown? ...)) instead of (is (thrown-with-msg? ...))

Patch: clj-1313-v3.patch

Screened by: Alex Miller

Environment

None

Attachments

3

Activity

Andy Fingerhut 
April 4, 2015 at 7:36 PM

clj-1313-v3.patch adds two other test corrections/improvements that were not in the -v2 patch. The change from doall to dorun is not really a correction, as much as cleaning up the fact that the return value of doall was discarded.

Andy Fingerhut 
January 31, 2014 at 9:29 PM

clj-1313-v2.diff is identical to clj-1313-v1.diff except that it removes the portion that conflicts with the latest Clojure master. That portion needs updating for a different reason anyway (ticket CLJ-1328), and is probably best put into a patch for that ticket.

Stuart Halloway 
January 31, 2014 at 6:36 PM

please update to apply cleanly on master

Andy Fingerhut 
December 23, 2013 at 9:11 AM

Patch clj-1313-v1.diff wraps (is ...) around several = expressions in unit tests that appeared to have been missing them, and changes several thrown? to thrown-with-msg? when there were regexes that were unused.

Completed

Details

Assignee

Reporter

Labels

Approval

Patch

Priority

Affects versions

Fix versions

Created December 23, 2013 at 9:07 AM
Updated July 18, 2015 at 1:20 AM
Resolved July 18, 2015 at 1:20 AM