Clojure

Unused local variable in PersistentVector.cons()

Details

  • Type: Enhancement Enhancement
  • Status: Open Open
  • Priority: Trivial Trivial
  • Resolution: Unresolved
  • Affects Version/s: Release 1.5, Release 1.6
  • Fix Version/s: None
  • Component/s: None
  • Labels:
  • Patch:
    Code
  • Approval:
    Triaged

Description

in src/jvm/clojure/lang/PersistentVector.java:168, there is an integer i being defined which is not being used anywhere in the method.

Patch: clj-1329-2.patch
Screened by: Alex Miller

  1. fix.patch
    22/Jan/14 12:08 AM
    0.4 kB
    Smit Shah
  2. clj-1329-2.patch
    29/Apr/15 2:28 PM
    0.7 kB
    Alex Miller

Activity

Hide
Stuart Halloway added a comment -

Smit, can you please submit a CA? http://clojure.org/contributing

Show
Stuart Halloway added a comment - Smit, can you please submit a CA? http://clojure.org/contributing
Hide
Smit Shah added a comment -

Stuart, I will send the CA via post ASAP.
It might take a couple of days to reach Rich though.

Show
Smit Shah added a comment - Stuart, I will send the CA via post ASAP. It might take a couple of days to reach Rich though.
Hide
Smit Shah added a comment -

Stuart, I have successfully submitted the CA (http://clojure.org/contributing).
I guess now merging this patch shouldn't be a problem

Show
Smit Shah added a comment - Stuart, I have successfully submitted the CA (http://clojure.org/contributing). I guess now merging this patch shouldn't be a problem
Hide
Alex Miller added a comment -

Thanks Smit!

Show
Alex Miller added a comment - Thanks Smit!
Hide
Andy Fingerhut added a comment -

Smit, instructions for creating a patch in the format expected by the screeners is given on the wiki page below. The one you have attached is not in the expected format.

http://dev.clojure.org/display/community/Developing+Patches

Show
Andy Fingerhut added a comment - Smit, instructions for creating a patch in the format expected by the screeners is given on the wiki page below. The one you have attached is not in the expected format. http://dev.clojure.org/display/community/Developing+Patches
Hide
Alex Miller added a comment -

Added new patch - same diff but proper format

Show
Alex Miller added a comment - Added new patch - same diff but proper format

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated: