Clojure

Unused local variable in PersistentVector.cons()

Details

  • Type: Enhancement Enhancement
  • Status: Closed Closed
  • Priority: Trivial Trivial
  • Resolution: Completed
  • Affects Version/s: Release 1.5, Release 1.6
  • Fix Version/s: Release 1.8
  • Component/s: None
  • Labels:
  • Patch:
    Code
  • Approval:
    Ok

Description

in src/jvm/clojure/lang/PersistentVector.java:168, there is an integer i being defined which is not being used anywhere in the method.

Patch: clj-1329-2.patch
Screened by: Alex Miller

  1. clj-1329-2.patch
    29/Apr/15 2:28 PM
    0.7 kB
    Alex Miller
  2. fix.patch
    22/Jan/14 12:08 AM
    0.4 kB
    Smit Shah

Activity

Hide
Stuart Halloway added a comment -

Smit, can you please submit a CA? http://clojure.org/contributing

Show
Stuart Halloway added a comment - Smit, can you please submit a CA? http://clojure.org/contributing
Stuart Halloway made changes -
Field Original Value New Value
Issue Type Defect [ 1 ] Enhancement [ 4 ]
Hide
Smit Shah added a comment -

Stuart, I will send the CA via post ASAP.
It might take a couple of days to reach Rich though.

Show
Smit Shah added a comment - Stuart, I will send the CA via post ASAP. It might take a couple of days to reach Rich though.
Alex Miller made changes -
Labels bug patch
Hide
Smit Shah added a comment -

Stuart, I have successfully submitted the CA (http://clojure.org/contributing).
I guess now merging this patch shouldn't be a problem

Show
Smit Shah added a comment - Stuart, I have successfully submitted the CA (http://clojure.org/contributing). I guess now merging this patch shouldn't be a problem
Hide
Alex Miller added a comment -

Thanks Smit!

Show
Alex Miller added a comment - Thanks Smit!
Alex Miller made changes -
Approval Triaged [ 10120 ]
Alex Miller made changes -
Description in src/jvm/clojure/lang/PersistentVector.java:168, there is an integer i being defined which is not being used anywhere in the method. in src/jvm/clojure/lang/PersistentVector.java:168, there is an integer i being defined which is not being used anywhere in the method.

https://github.com/clojure/clojure/blob/master/src/jvm/clojure/lang/PersistentVector.java#L168
Summary Unused variable in PersistentVector Unused local variable in PersistentVector.cons()
Alex Miller made changes -
Labels collections
Alex Miller made changes -
Labels collections collections ft
Hide
Andy Fingerhut added a comment -

Smit, instructions for creating a patch in the format expected by the screeners is given on the wiki page below. The one you have attached is not in the expected format.

http://dev.clojure.org/display/community/Developing+Patches

Show
Andy Fingerhut added a comment - Smit, instructions for creating a patch in the format expected by the screeners is given on the wiki page below. The one you have attached is not in the expected format. http://dev.clojure.org/display/community/Developing+Patches
Alex Miller made changes -
Labels collections ft collections
Hide
Alex Miller added a comment -

Added new patch - same diff but proper format

Show
Alex Miller added a comment - Added new patch - same diff but proper format
Alex Miller made changes -
Description in src/jvm/clojure/lang/PersistentVector.java:168, there is an integer i being defined which is not being used anywhere in the method.

https://github.com/clojure/clojure/blob/master/src/jvm/clojure/lang/PersistentVector.java#L168
in src/jvm/clojure/lang/PersistentVector.java:168, there is an integer i being defined which is not being used anywhere in the method.

*Patch:* clj-1329-2.patch
*Screened by:* Alex Miller
Attachment clj-1329-2.patch [ 14092 ]
Labels collections collections ft
Rich Hickey made changes -
Approval Triaged [ 10120 ] Vetted [ 10003 ]
Fix Version/s Release 1.8 [ 10254 ]
Alex Miller made changes -
Approval Vetted [ 10003 ] Screened [ 10004 ]
Rich Hickey made changes -
Approval Screened [ 10004 ] Ok [ 10007 ]
Stuart Halloway made changes -
Resolution Completed [ 1 ]
Status Open [ 1 ] Closed [ 6 ]

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: