Clojure

Primitive vectors should use new hash

Details

  • Type: Enhancement Enhancement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Completed
  • Affects Version/s: Release 1.6
  • Fix Version/s: Release 1.6
  • Component/s: None
  • Labels:
    None
  • Patch:
    Code and Test
  • Approval:
    Ok

Description

Primitive vectors created via vector-of still use Java hashCode for hasheq.

Solution: Make primitive vectors implement IHashEq and call Murmur3.hashOrdered().

Patch: clj-1331-v2.patch
Depends on: CLJ-1338 (must be applied first)

  1. clj-1331-v1.diff
    29/Jan/14 6:03 PM
    2 kB
    Andy Fingerhut
  2. clj-1331-v2.patch
    04/Feb/14 5:05 PM
    2 kB
    Alex Miller

Activity

Andy Fingerhut made changes -
Field Original Value New Value
Attachment clj-1331-v1.diff [ 12726 ]
Andy Fingerhut made changes -
Patch Code and Test [ 10002 ]
Alex Miller made changes -
Approval Vetted [ 10003 ]
Fix Version/s Release 1.6 [ 10157 ]
Alex Miller made changes -
Description Primitive vectors created via vector-of still use Java hashCode for hasheq Primitive vectors created via vector-of still use Java hashCode for hasheq.

*Solution:* Make primitive vectors implement IHashEq and call Murmur3.hashOrdered().

*Patch:* clj-1331-v2.patch
*Depends on:* CLJ-1338 (must be applied first)

Attachment clj-1331-v2.patch [ 12755 ]
Alex Miller made changes -
Issue Type Defect [ 1 ] Enhancement [ 4 ]
Stuart Halloway made changes -
Approval Vetted [ 10003 ] Screened [ 10004 ]
Rich Hickey made changes -
Approval Screened [ 10004 ] Ok [ 10007 ]
Stuart Halloway made changes -
Resolution Completed [ 1 ]
Status Open [ 1 ] Closed [ 6 ]

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: