Details
-
Type:
Defect
-
Status:
Closed
-
Priority:
Blocker
-
Resolution: Completed
-
Affects Version/s: Release 1.6
-
Fix Version/s: Release 1.6
-
Component/s: None
-
Labels:None
-
Patch:Code and Test
-
Approval:Ok
Description
After late Jan 2014 changes to hash functions, PersistentList$EmptyList and (lazy-seq) were left behind:
user=> (= '() (lazy-seq) [])
true
user=> (map hash ['() (lazy-seq) []])
(1 1 -2017569654)
user=> (map class ['() (lazy-seq) []])
(clojure.lang.PersistentList$EmptyList clojure.lang.LazySeq clojure.lang.PersistentVector)
PersistentQueue/EMPTY was updated, so should not need any change.
Solution: Update LazySeq.hasheq() and make EmptyList implement IHashEq. EmptyList now creates a static constant for the hash value of an empty ordered collection and returns the constant for hasheq. An alternative would be to have Murmur3 have this constant instead.
Patch: clj-1335-v2.patch
Depends on: CLJ-1338, CLJ-1339, CLJ-1331 (must be applied first)
Patch:
Patch clj-1335-v1.diff adds tests that assume the patch clj-1331-v1.diff on ticket
CLJ-1331have already been committed. If it is desired to combine these into one patch, or commit this one without that one, I can eliminate that dependency.Makes PersistentList$EmptyList implement IHashEq interface with a straightforward implementation of hasheq(), comments out empty LazySeq special case check that caused it to return old hash value, and fixes a NullPointerException for primitive vectors discovered by the new tests added.
CLJ-1331have already been committed. If it is desired to combine these into one patch, or commit this one without that one, I can eliminate that dependency. Makes PersistentList$EmptyList implement IHashEq interface with a straightforward implementation of hasheq(), comments out empty LazySeq special case check that caused it to return old hash value, and fixes a NullPointerException for primitive vectors discovered by the new tests added.