Clojure

Add functions for external collection hashing

Details

  • Type: Enhancement Enhancement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Completed
  • Affects Version/s: Release 1.6
  • Fix Version/s: Release 1.6
  • Component/s: None
  • Labels:
    None
  • Patch:
    Code
  • Approval:
    Ok

Description

External collections wishing to implement hasheq appropriately must follow the advice at http://clojure.org/data_structures#hash. To simplify the implementation (and avoid unwanted dependencies on the internal Murmur3 class), add two new functions hash-ordered-coll and hash-unordered-coll that provide a proper collection hasheq over entire collections.

Patch: clj-1348-3.patch (fixes [k v])

  1. clj-1348-1.patch
    10/Feb/14 9:27 AM
    1 kB
    Alex Miller
  2. clj-1348-2.patch
    10/Feb/14 3:40 PM
    2 kB
    Stuart Halloway
  3. clj-1348-3.patch
    12/Feb/14 11:46 AM
    1 kB
    Alex Miller

Activity

Alex Miller made changes -
Field Original Value New Value
Approval Vetted [ 10003 ]
Fix Version/s Release 1.6 [ 10157 ]
Assignee Alex Miller [ alexmiller ]
Hide
Alex Miller added a comment -

Added patch. Will need to be refreshed once other patches go in.

Show
Alex Miller added a comment - Added patch. Will need to be refreshed once other patches go in.
Alex Miller made changes -
Patch Code [ 10001 ]
Description External collections wishing to implement hasheq appropriately must follow the advice at http://clojure.org/data_structures#hash. To simplify the implementation (and avoid unwanted dependencies on the internal Murmur3 class), add two new functions {{hash-ordered-coll}} and {{hash-unordered-coll}} that provide a proper collection hasheq over entire collections.

External collections wishing to implement hasheq appropriately must follow the advice at http://clojure.org/data_structures#hash. To simplify the implementation (and avoid unwanted dependencies on the internal Murmur3 class), add two new functions {{hash-ordered-coll}} and {{hash-unordered-coll}} that provide a proper collection hasheq over entire collections.

*Patch:* clj-1348-1.patch
Attachment clj-1348-1.patch [ 12774 ]
Stuart Halloway made changes -
Description External collections wishing to implement hasheq appropriately must follow the advice at http://clojure.org/data_structures#hash. To simplify the implementation (and avoid unwanted dependencies on the internal Murmur3 class), add two new functions {{hash-ordered-coll}} and {{hash-unordered-coll}} that provide a proper collection hasheq over entire collections.

*Patch:* clj-1348-1.patch
External collections wishing to implement hasheq appropriately must follow the advice at http://clojure.org/data_structures#hash. To simplify the implementation (and avoid unwanted dependencies on the internal Murmur3 class), add two new functions {{hash-ordered-coll}} and {{hash-unordered-coll}} that provide a proper collection hasheq over entire collections.

*Patch:* clj-1348-2.patch (fixes spelling in first patch)
Attachment clj-1348-2.patch [ 12775 ]
Stuart Halloway made changes -
Resolution Completed [ 1 ]
Status Open [ 1 ] Closed [ 6 ]
Hide
Alex Miller added a comment -

oops

Show
Alex Miller added a comment - oops
Alex Miller made changes -
Approval Vetted [ 10003 ] Screened [ 10004 ]
Status Closed [ 6 ] Reopened [ 4 ]
Resolution Completed [ 1 ]
Hide
Rich Hickey added a comment -

[k,v] => [k v]

Show
Rich Hickey added a comment - [k,v] => [k v]
Hide
Alex Miller added a comment -

New patch fixing [k v].

Show
Alex Miller added a comment - New patch fixing [k v].
Alex Miller made changes -
Description External collections wishing to implement hasheq appropriately must follow the advice at http://clojure.org/data_structures#hash. To simplify the implementation (and avoid unwanted dependencies on the internal Murmur3 class), add two new functions {{hash-ordered-coll}} and {{hash-unordered-coll}} that provide a proper collection hasheq over entire collections.

*Patch:* clj-1348-2.patch (fixes spelling in first patch)
External collections wishing to implement hasheq appropriately must follow the advice at http://clojure.org/data_structures#hash. To simplify the implementation (and avoid unwanted dependencies on the internal Murmur3 class), add two new functions {{hash-ordered-coll}} and {{hash-unordered-coll}} that provide a proper collection hasheq over entire collections.

*Patch:* clj-1348-3.patch (fixes [k v])
Attachment clj-1348-3.patch [ 12782 ]
Rich Hickey made changes -
Approval Screened [ 10004 ] Ok [ 10007 ]
Stuart Halloway made changes -
Resolution Completed [ 1 ]
Status Reopened [ 4 ] Closed [ 6 ]

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: