missing field munging when recreating deftypes serialized into byte code

Description

deftypes with fields whose names get munged fail when constructed in data reader functions.

user=> (deftype Foo [hello-world])
user.Foo
user=> (alter-var-root #'default-data-readers assoc 'foo (fn [x] (->Foo x)))
{inst #'clojure.instant/read-instant-date, uuid #'clojure.uuid/default-uuid-reader, foo #object[user$eval12$fn__13 0x23c89df9 "user$eval12$fn__13@23c89df9"]}
user=> #foo "1"
CompilerException java.lang.IllegalArgumentException: No matching field found: hello-world for class user.Foo, compiling:(NO_SOURCE_PATH:0:0)

Cause: To embed deftypes in the bytecode the compiler emits the value of each field, then emits a call to the deftypes underlying class's constructor. To get a list of fields the compiler calls .getBasis. The getBasis fields are the "clojure" level field names of the deftype, which the actual "jvm" level field names have been munged (replacing - with _, etc), so the compiler tries to generate code to set values on non-existent fields.

Approach: Munge the field name before emitting it in bytecode.
Patch: clj-1399-with-test.diff
Screened by: Alex Miller

Environment

None

Attachments

clj-1399-with-test.diff

29 Apr, 2015

clj-1399.diff

02 Apr, 2014

Activity

Kevin Downey

April 29, 2015 at 7:20 PM

clj-1399-with-test.diff adds a test

Alex Miller

April 29, 2015 at 5:36 PM

Could the patch have a test?

Chas Emerick

April 2, 2014 at 10:57 PM

FWIW, this was precipitated by real experience (I think I created the refheap paste). The workaround is easy (don't use dashes in field names of deftypes you want to return from data reader functions), but I wouldn't expect anyone to guess that that wasn't already oversensitized to munging edge cases.

Kevin Downey

April 2, 2014 at 10:39 PM

this patch fixes the issue on the latest master for me

Kevin Downey

April 2, 2014 at 10:26 PM

reproducing case

$ rlwrap java -server -Xmx1G -Xms1G -jar /Users/hiredman/src/clojure/target/clojure-1.6.0-master-SNAPSHOT.jar
Clojure 1.6.0-master-SNAPSHOT
user=> (deftype Foo [hello-world])
user.Foo
user=> (alter-var-root #'default-data-readers assoc 'foo (fn [x] (Foo. x)))
{foo #<user$eval6$fn__7 user$eval6$fn__7@2f953efd>, inst #'clojure.instant/read-instant-date, uuid #'clojure.uuid/default-uuid-reader}
user=> #foo "1"
CompilerException java.lang.IllegalArgumentException: No matching field found: hello-world for class user.Foo, compiling:(NO_SOURCE_PATH:0:0)
user=>

Resize work item view side panel

Completed

Details

Assignee

Unassigned

Reporter

Kevin Downey

Labels

compilerdeftypeft

Approval

Patch

Code and Test

Priority

Critical

Affects versions

Release 1.7

Fix versions

Release 1.8

Created April 2, 2014 at 10:13 PM

Updated July 18, 2015 at 12:55 AM

Resolved July 18, 2015 at 12:55 AM