Details
-
Type:
Defect
-
Status:
Closed
-
Priority:
Critical
-
Resolution: Completed
-
Affects Version/s: Release 1.7
-
Fix Version/s: Release 1.8
-
Component/s: None
-
Patch:Code and Test
-
Approval:Ok
Description
deftypes with fields whose names get munged fail when constructed in data reader functions.
user=> (deftype Foo [hello-world]) user.Foo user=> (alter-var-root #'default-data-readers assoc 'foo (fn [x] (->Foo x))) {inst #'clojure.instant/read-instant-date, uuid #'clojure.uuid/default-uuid-reader, foo #object[user$eval12$fn__13 0x23c89df9 "user$eval12$fn__13@23c89df9"]} user=> #foo "1" CompilerException java.lang.IllegalArgumentException: No matching field found: hello-world for class user.Foo, compiling:(NO_SOURCE_PATH:0:0)
Cause: To embed deftypes in the bytecode the compiler emits the value of each field, then emits a call to the deftypes underlying class's constructor. To get a list of fields the compiler calls .getBasis. The getBasis fields are the "clojure" level field names of the deftype, which the actual "jvm" level field names have been munged (replacing - with _, etc), so the compiler tries to generate code to set values on non-existent fields.
Approach: Munge the field name before emitting it in bytecode.
Patch: clj-1399-with-test.diff
Screened by: Alex Miller
reproducing case
$ rlwrap java -server -Xmx1G -Xms1G -jar /Users/hiredman/src/clojure/target/clojure-1.6.0-master-SNAPSHOT.jar Clojure 1.6.0-master-SNAPSHOT user=> (deftype Foo [hello-world]) user.Foo user=> (alter-var-root #'default-data-readers assoc 'foo (fn [x] (Foo. x))) {foo #<user$eval6$fn__7 user$eval6$fn__7@2f953efd>, inst #'clojure.instant/read-instant-date, uuid #'clojure.uuid/default-uuid-reader} user=> #foo "1" CompilerException java.lang.IllegalArgumentException: No matching field found: hello-world for class user.Foo, compiling:(NO_SOURCE_PATH:0:0) user=>$ rlwrap java -server -Xmx1G -Xms1G -jar /Users/hiredman/src/clojure/target/clojure-1.6.0-master-SNAPSHOT.jar Clojure 1.6.0-master-SNAPSHOT user=> (deftype Foo [hello-world]) user.Foo user=> (alter-var-root #'default-data-readers assoc 'foo (fn [x] (Foo. x))) {foo #<user$eval6$fn__7 user$eval6$fn__7@2f953efd>, inst #'clojure.instant/read-instant-date, uuid #'clojure.uuid/default-uuid-reader} user=> #foo "1" CompilerException java.lang.IllegalArgumentException: No matching field found: hello-world for class user.Foo, compiling:(NO_SOURCE_PATH:0:0) user=>