The compiler ignores too few or too many arguments to throw

Description

The compiler does not fail on "malformed" throw forms with less than or greater than one arg:

user=> (defn foo [] (throw))
#'user/foo

user=> (foo)
NullPointerException   user/foo (NO_SOURCE_FILE:1)

user=> (defn bar [] (throw Exception baz))
#'user/bar

user=> (bar)
ClassCastException java.lang.Class cannot be cast to java.lang.Throwable  user/bar (NO_SOURCE_FILE:1)

; This one works, but ignored-symbol, should probably not be ignored
user=> (defn quux [] (throw (Exception. "Works!") ignored-symbol))
#'user/quux

user=> (quux)
Exception Works!  user/quux (NO_SOURCE_FILE:1)

Approach: Count forms and throw an appropriate exception if arity != 1.

Patch: clj-1456-5.patch

Screened by: Alex Miller

Environment

None

Attachments

clj-1456-5.patch

09 Oct, 2015

clj-1456-4.patch

04 May, 2015

v3_0001-CLJ-1456-counting-forms-to-catch-malformed-throw-for.patch

30 Aug, 2014

Activity

Alex Miller

October 9, 2015 at 2:33 PM

Patch -5 updated to apply to master and to give more context lines in diff, no semantic changes, attribution retained.

Alex Miller

May 4, 2015 at 3:31 PM

-4 patch is same, just refreshed to apply to master

Alf Kristian Støyle

January 10, 2015 at 3:12 PM

Removed both obsolete attachments. So shouldn't be confusing any more

Andy Fingerhut

January 9, 2015 at 12:07 AM

Alf, while JIRA can handle multiple attachments for the same ticket with the same name, it can get confusing for people trying to determine which one with the same name is meant. Could you remove or rename one of your identically-named attachments? Instructions for deleting patches are in the "Removing patches" section on this wiki page: http://dev.clojure.org/display/community/Developing+Patches

Alf Kristian Støyle

August 30, 2014 at 8:18 AM

It was easy to fix the patch. Uploaded the new patch v3_0001-CLJ-1456-counting-forms-to-catch-malformed-throw-for.patch, which applies cleanly to the current master.

Resize work item view side panel

Completed

Details

Assignee

Unassigned

Reporter

Alf Kristian Støyle

Labels

compilerft

Approval

Patch

Code and Test

Priority

Major

Affects versions

Release 1.6

Fix versions

Release 1.8

Created June 30, 2014 at 5:52 PM

Updated October 13, 2015 at 3:37 AM

Resolved October 13, 2015 at 3:37 AM