clojure.test.junit/with-junit-output doesn't handle multiple expressions

Description

From the docstring description, and the use of ~@body, the intent of with-junit-output was to support a body containing multiple forms (for side-effects). However, calling it with multiple expressions will yield an error about the bindings in the let form.

Cause: The ~@body in the macro is spliced into code expecting a single expression.

Approach: Wrap a (do ) around the ~@body.

Patch: clj-1485.patch

Screened by: Alex Miller

Environment

None

Attachments

1

Activity

Show:

Howard Lewis Ship July 29, 2014 at 10:59 PM

Patch for issue

Completed

Details

Assignee

Reporter

Approval

Ok

Patch

Code

Priority

Affects versions

Fix versions

Created July 29, 2014 at 10:47 PM
Updated July 31, 2015 at 9:39 PM
Resolved July 31, 2015 at 9:39 PM