Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Audit IReduce usages for proper Reduced handling

Description

Rich asked that we make sure that all usages of IReduce properly handle Reduced semantics.

Approach: I did a "Find Usages" in InteliJ and updated usages of IReduce as needed.

Example: Before the patch:

Patch: clj-1537-v3.diff
Screened by: Alex Miller

Environment

None

Attachments

4

Activity

Show:

Nicola Mometto November 15, 2014 at 12:08 AM

I'm closing this ticket again and opening a different ticket for the new patch, as asked privately by Alex Miller

Nicola Mometto November 14, 2014 at 7:00 PM

The attached patch (clj-1537-gvec-ArraySeq.patch) fixes the remaining IReduce impls that don't correctly handle Reduced

Nicola Mometto November 14, 2014 at 7:00 PM

I've reopened this issue as there are still instances of IReduce implementations that don't handle Reduced:

Timothy Baldridge October 3, 2014 at 8:23 PM

clj-1537-v2.diff didn't properly deref the reduced box. clj-1537-v3.diff does this now.

Timothy Baldridge October 3, 2014 at 4:29 PM

Failure examples from master, are added to the description.

Completed

Details

Assignee

Reporter

Patch

Code

Priority

Affects versions

Fix versions

Created September 26, 2014 at 5:16 PM
Updated November 15, 2014 at 12:08 AM
Resolved November 15, 2014 at 12:08 AM