Clojure

(keyword "a/b") => ns nil, name a/b; should be ns a, name b

Details

  • Type: Defect Defect
  • Status: Closed Closed
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: Release 1.1
  • Component/s: None
  • Labels:
    None
  • Approval:
    Ok

Description

From: http://groups.google.com/group/clojure/browse_thread/thread/c792fd218bedea1f

for generated keywords, seems dodgy
(keyword "aaaaa/bbbbb") => :aaaaa/bbbbb
(name (keyword "aaaaa/bbbbb")) => "aaaaa/bbbbb"
(namespace (keyword "aaaaa/bbbbb")) => nil

It would seem cleaner if the java Keyword.intern() and Symbol.intern()
methods were symmetrical and used the same way in core.clj.

Activity

Hide
Assembla Importer added a comment -

scgilardi said: [file:aGf_3wB8Cr3PfNeJe5afGb]

Show
Assembla Importer added a comment - scgilardi said: [file:aGf_3wB8Cr3PfNeJe5afGb]
Hide
Assembla Importer added a comment -

scgilardi said: Description of fix-154.patch:

  • added intern(String nsname) to Keyword.java
  • changed clojure.core/keyword to call it
  • updated clojure.core/symbol and clojure.core/keyword to new static call syntax
  • added tests to reader.clj using corrected keyword, duplicating similar tests for symbol, and adding tests of keyword constructed from a symbol
Show
Assembla Importer added a comment - scgilardi said: Description of fix-154.patch:
  • added intern(String nsname) to Keyword.java
  • changed clojure.core/keyword to call it
  • updated clojure.core/symbol and clojure.core/keyword to new static call syntax
  • added tests to reader.clj using corrected keyword, duplicating similar tests for symbol, and adding tests of keyword constructed from a symbol
Hide
Assembla Importer added a comment -

importer said: (In [[r:a1b4a33bb8ccf739c481754fc563117ed3604c75]]) fixed keyword ctor, added tests, fix #154

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

Show
Assembla Importer added a comment - importer said: (In [[r:a1b4a33bb8ccf739c481754fc563117ed3604c75]]) fixed keyword ctor, added tests, fix #154 Signed-off-by: Chouser <chouser@n01se.net> Branch: master

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: