Clojure

ant targets should fail on error, also test print report correctly

Details

  • Type: Defect Defect
  • Status: Closed Closed
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: Release 1.1
  • Component/s: None
  • Labels:
    None
  • Approval:
    Ok

Description

I found and fixed 3 problems with the ant task for running tests:

  1. compile-clojure target should fail when the compilation fails so more targets aren't run and ant process returns error
  2. test target should fail when the tests fail, not just print the report.
  3. when the test target is used with compile (eg, ant all test), the report is not printed at all

Activity

Hide
Assembla Importer added a comment -

mikehinchey said: [file:dXurvSG-Sr3OZ9eJe5aVNr]: patch to fix ant

Show
Assembla Importer added a comment - mikehinchey said: [file:dXurvSG-Sr3OZ9eJe5aVNr]: patch to fix ant
Hide
Assembla Importer added a comment -

mikehinchey said: Fixed by setting java failonerror to true for both compile and test. Most ant tasks fail by default, but not java.

Also, wrote a special function for running tests to be used by ant, so it would print properly and throw on test failures. It wasn't printing properly when run in the same ant process as the compile because out and test-out are bound during compile, so the report was printed to nowhere.

Show
Assembla Importer added a comment - mikehinchey said: Fixed by setting java failonerror to true for both compile and test. Most ant tasks fail by default, but not java. Also, wrote a special function for running tests to be used by ant, so it would print properly and throw on test failures. It wasn't printing properly when run in the same ant process as the compile because out and test-out are bound during compile, so the report was printed to nowhere.
Hide
Assembla Importer added a comment -

mikehinchey said: (In [[r:abca86ea023080fd4ceed24b9887a653a56722eb]]) fix #168, ant targets should fail on error, also test print report correctly

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

Show
Assembla Importer added a comment - mikehinchey said: (In [[r:abca86ea023080fd4ceed24b9887a653a56722eb]]) fix #168, ant targets should fail on error, also test print report correctly Signed-off-by: Chouser <chouser@n01se.net> Branch: master

People

  • Assignee:
    Unassigned
    Reporter:
    Anonymous
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: