Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Recently-added test fails on Windows

Description

Inside of deftest test-pprint-calendar in file test/clojure/test_clojure/pprint/test_pretty.clj, it compares the output of pprint against a string ending in a newline character. This works fine on Linux and Mac OS X, but fails on Windows systems, as there the pprint'ed string ends with a carriage return followed by newline.

Approach: A straightforward fix is to call clojure.string/split-lines on the string, which has a return value that is independent of OS.

Screened: Alex Miller

Environment

Windows

Attachments

1

Activity

Alex Miller 
September 8, 2015 at 2:02 PM

Since this breaks the build on windows, I added it to 1.8 and screened it.

Andy Fingerhut 
September 6, 2015 at 10:21 PM

Patch CLJ-1812-fix1.patch dated Sep 6 2015 allows the test to pass on Windows as well as Mac OS X.

Completed

Details

Assignee

Reporter

Labels

Approval

Patch

Priority

Affects versions

Fix versions

Created September 6, 2015 at 10:16 PM
Updated September 11, 2015 at 12:34 PM
Resolved September 11, 2015 at 12:34 PM