Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Allow load to be redefined

Description

With direct linking of core, we have lost the ability to easily redef load (as calls to load inside Clojure are direct linked).

Proposed: make load dynamic (dynamic vars are not direct linked)

Patch: clj-1845.patch
See: https://groups.google.com/d/msg/clojure/_AGdLHSg41Q/q8LeplkrBQAJ

------------------------------------------
Re-opened because the initial declare of load is not declared as ^:dynamic and thus functions that use load between the initial forward declare and the later actual declaration were still allowing direct linking.

Because we are adding ^:redef, I rolled the changes into CLJ-1851 instead. The only thing here is a new test (which will fail till CLJ-1851 is applied).

Test patch: clj-1845-test.patch (NEW)
See also: CLJ-1851
Screened by: Alex Miller

Environment

None

Attachments

3

Activity

Show:

Andy Fingerhut December 5, 2015 at 9:13 PM

It appears that CLJ-1845, CLJ-1851, and CLJ-1856 are committed now, and can be closed as complete?

Alex Miller November 20, 2015 at 5:00 PM

New test patch that applies to master

Ambrose Bonnaire-Sergeant November 20, 2015 at 4:12 PM

Attached direct linking test.

Alex Miller November 20, 2015 at 3:56 PM

Actually, if you wanted to make a patch for a test, that would be useful.

Alex Miller November 20, 2015 at 3:55 PM

No patch - this interacts with another change and I may just roll them together.

Completed

Details

Assignee

Reporter

Approval

Ok

Patch

Code

Priority

Affects versions

Fix versions

Created November 10, 2015 at 3:40 PM
Updated December 6, 2015 at 2:15 AM
Resolved December 6, 2015 at 2:15 AM