Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Update parameter name to reflect docstring

Description

The docstrings for `zero?`, `pos?`, and `neg?` reference `num` but the parameter is named `x`.

Proposed: Modify code to use "num" to match docstring as "num" is more descriptive than "x".

Patch: CLJ-1859-Update-parameter-name-to-reflect-docstring.patch

Prescreened by: Alex Miller

Environment

None

Attachments

1
  • 30 Nov 2015, 07:23 PM

Activity

Marc O'Morain August 19, 2017 at 9:26 PM

I've been going through issues that I have logged and writing some patches this evening, and I came to this issue through CLJ-2121, but I see that there is already a patch here. Can this be considered for 1.9? Seems un-controversial.

Erik Assum March 4, 2017 at 8:32 PM

https://clojure.atlassian.net/browse/CLJ-2121#icft=CLJ-2121 should be closed as a duplicate of this, I assume?

Matthew Boston November 30, 2015 at 7:22 PM

Thanks, Alex. I was trying to follow the existing pattern that the inline functions have shorter parameter names. New patch attached.

Alex Miller November 30, 2015 at 7:14 PM

The inline fns should be updated too.

Completed

Details

Assignee

Reporter

Labels

Approval

Patch

Priority

Fix versions

Created November 30, 2015 at 7:08 PM
Updated September 7, 2017 at 8:45 PM
Resolved September 7, 2017 at 8:45 PM