Clojure

*file* returns "NO_SOURCE_PATH", but the doc says it should be nil

Details

  • Type: Defect Defect
  • Status: In Progress In Progress
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: Approved Backlog
  • Fix Version/s: Release 1.6
  • Component/s: None
  • Labels:
    None
  • Patch:
    Code
  • Approval:
    Ok

Description

According to http://clojure.org/api, *file* should return nil in the repl, but it returns "NO_SOURCE_PATH".

This has been true for a long time. Latest patch changes only the docstring of *file* to accurately reflect current behavior.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Assembla Importer added a comment -

Converted from http://www.assembla.com/spaces/clojure/tickets/196

Show
Assembla Importer added a comment - Converted from http://www.assembla.com/spaces/clojure/tickets/196
Stuart Halloway made changes -
Field Original Value New Value
Assignee Stuart Halloway [ stu ]
Alexander Redington made changes -
Reporter Alexander Redington [ aredington ]
Priority Blocker [ 1 ]
Approval Vetted
Hide
Permalink
Colin Jones added a comment -

I think this is a pretty trivial docstring fix - "NO_SOURCE_PATH" has been the default value of file since 3dd4c1cf18ea8456b5b4aec607cd54ecfdd85eea (April 2009).

Show
Colin Jones added a comment - I think this is a pretty trivial docstring fix - "NO_SOURCE_PATH" has been the default value of file since 3dd4c1cf18ea8456b5b4aec607cd54ecfdd85eea (April 2009).
Colin Jones made changes -
Attachment 0001-Fix-docstring-for-file-refs-196.patch [ 10063 ]
Stuart Sierra made changes -
Fix Version/s Approved Backlog [ 10034 ]
Fix Version/s Backlog [ 10035 ]
Affects Version/s Approved Backlog [ 10034 ]
Priority Blocker [ 1 ] Minor [ 4 ]
Stuart Sierra made changes -
Patch Code
Hide
Permalink
Andy Fingerhut added a comment -

Colin's patch still applies cleanly to latest master as of Feb 24, 2012.

Show
Andy Fingerhut added a comment - Colin's patch still applies cleanly to latest master as of Feb 24, 2012.
Hide
Permalink
Stuart Sierra added a comment -

Docstring only. Screened.

Show
Stuart Sierra added a comment - Docstring only. Screened.
Stuart Sierra made changes -
Approval Vetted [ 10003 ] Screened [ 10004 ]
Stuart Sierra made changes -
Description According to http://clojure.org/api, {{*file*}} should return nil in the repl, but it returns "NO_SOURCE_PATH".

To reproduce;
{code}
> java -cp /usr/local/clojure-git/clojure.jar clojure.lang.Repl
Clojure 1.1.0-alpha-SNAPSHOT
user=> *file*
"NO_SOURCE_PATH"
user=>
{code}

I've tried this with 1.0 and with current git. This has not been discussed in the group. I figure this is trivial enough to skip the group. 		According to http://clojure.org/api, {{*file*}} should return nil in the repl, but it returns "NO_SOURCE_PATH".

This has been true for a long time. Latest patch changes only the docstring of {{*file*}} to accurately reflect current behavior.
Hide
Permalink
Stuart Sierra added a comment -

Rescreened. Still applies on latest master.

Show
Stuart Sierra added a comment - Rescreened. Still applies on latest master.
Stuart Sierra made changes -
Waiting On richhickey
Steve Miner made changes -
Description According to http://clojure.org/api, {{*file*}} should return nil in the repl, but it returns "NO_SOURCE_PATH".

This has been true for a long time. Latest patch changes only the docstring of {{*file*}} to accurately reflect current behavior. 		According to http://clojure.org/api, \*file* should return nil in the repl, but it returns "NO_SOURCE_PATH".

This has been true for a long time. Latest patch changes only the docstring of \*file* to accurately reflect current behavior.
Hide
Permalink
Rich Hickey added a comment -

I'd rather promise nothing than promise this forever.

Show
Rich Hickey added a comment - I'd rather promise nothing than promise this forever.
Rich Hickey made changes -
Approval Screened [ 10004 ] Not Approved [ 10008 ]
Hide
Permalink
Colin Jones added a comment -

The second patch avoids promising the return value. For clarity, it does mention the lack of guarantee instead of omitting any mention.

Show
Colin Jones added a comment - The second patch avoids promising the return value. For clarity, it does mention the lack of guarantee instead of omitting any mention.
Colin Jones made changes -
Attachment 0002-Don-t-promise-the-value-of-file-in-the-REPL.patch [ 11582 ]
Hide
Permalink
Christopher Redinger added a comment -

Patch applies cleanly and makes documentation more correct.

Show
Christopher Redinger added a comment - Patch applies cleanly and makes documentation more correct.
Christopher Redinger made changes -
Approval Not Approved [ 10008 ] Screened [ 10004 ]
Rich Hickey made changes -
Approval Screened [ 10004 ] Ok [ 10007 ]
Fix Version/s Approved Backlog [ 10034 ]
Fix Version/s Release 1.6 [ 10157 ]

People

Vote (2)
Watch (2)

Dates

  • Created:
    Updated:
Atlassian JIRA (v4.4#649-r158309) | Report a problem
Powered by a free Atlassian JIRA open source license for Clojure. Try JIRA - bug tracking software for your team.