[spec] s/explain of evaluated predicate yields :s/unknown

Description

Got:

Expected to receive a description of the failing predicate as in:

Cause: specize was falling through on these cases to Object and just returning unknown.

Proposed:
Special handling for 2 cases:
1. Sets - explictly catch IPersistentSet and use the set as the form.
2. Functions - demunge the function name and use the qualified function name symbol as the form. Add a special check for anonymous functions and revert to ::unknown for those (not much we can do with an eval'ed anonymous function).

Patch: clj-2068-4.patch

Environment

None

Attachments

4

Activity

Show:

Alex Miller June 26, 2018 at 5:18 PM

Applied

Alex Miller June 18, 2018 at 4:51 PM

Updated -4 to apply to master, no semantic changes.

Alex Miller May 10, 2017 at 6:07 PM

Updated patch to apply to spec.alpha instead.

Ghadi Shayban March 10, 2017 at 6:57 PM

Extending Specize to IFn may incur the wrath of CLJ-1152

Alex Miller March 10, 2017 at 5:39 PM

Yes, I think that would make sense.

Completed

Details

Assignee

Reporter

Labels

Approval

Patch

Priority

Affects versions

Fix versions

Created November 23, 2016 at 7:46 PM
Updated June 26, 2018 at 5:18 PM
Resolved June 26, 2018 at 5:18 PM