Clojure

Unifying the array support for primitives (part 1)

Details

  • Type: Enhancement Enhancement
  • Status: Closed Closed
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: Release 1.1
  • Component/s: None
  • Labels:
    None
  • Approval:
    Ok

Description

Activity

Hide
Assembla Importer added a comment -

timothypratley said: [file:ab7__AZOur3RCOeJe5afGb]: copy+paste solution

Show
Assembla Importer added a comment - timothypratley said: [file:ab7__AZOur3RCOeJe5afGb]: copy+paste solution
Hide
Assembla Importer added a comment -

timothypratley said: Straightforward approach of adding boolean/byte/char/short in similar fashion to existing. I've marked this as (part 1) as it adds the missing features but there still might be some thinking required on how to 'unify' and/or reduce boilerplate. Happy to work on further if any suggestions.

Please note, have added tests as part of patch.

Show
Assembla Importer added a comment - timothypratley said: Straightforward approach of adding boolean/byte/char/short in similar fashion to existing. I've marked this as (part 1) as it adds the missing features but there still might be some thinking required on how to 'unify' and/or reduce boilerplate. Happy to work on further if any suggestions. Please note, have added tests as part of patch.
Hide
Assembla Importer added a comment -

timothypratley said: Re-assigning to you Rich as I'm not sure what the process is from here.

Show
Assembla Importer added a comment - timothypratley said: Re-assigning to you Rich as I'm not sure what the process is from here.
Hide
Assembla Importer added a comment -

timothypratley said: [file:d30jsYZOWr3QYEeJe5aVNr]: added some more tests

Show
Assembla Importer added a comment - timothypratley said: [file:d30jsYZOWr3QYEeJe5aVNr]: added some more tests
Hide
Assembla Importer added a comment -

chouser@n01se.net said: That last patch looks good to me. Not much can be done to reduce boilerplate in the Java. I suppose a private macro could be used for the repetition in Clojure, but I don't know if that's necessary. The . forms could be switched to a more "modern" format, if you're looking for extra ways to clean it up.

As for process, unless you want to make above changes, you're done. Next up Rich comments on or approves the patch.

Show
Assembla Importer added a comment - chouser@n01se.net said: That last patch looks good to me. Not much can be done to reduce boilerplate in the Java. I suppose a private macro could be used for the repetition in Clojure, but I don't know if that's necessary. The . forms could be switched to a more "modern" format, if you're looking for extra ways to clean it up. As for process, unless you want to make above changes, you're done. Next up Rich comments on or approves the patch.
Hide
Assembla Importer added a comment -

timothypratley said: Ok I'll add those changes

Show
Assembla Importer added a comment - timothypratley said: Ok I'll add those changes

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: