Clojure

Adding provenance of deprecation warnings to the LispReader

Details

  • Type: Enhancement Enhancement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Declined
  • Affects Version/s: None
  • Fix Version/s: Release 1.3
  • Component/s: None
  • Labels:
    None
  • Approval:
    Vetted

Description

The LispReader has some deprecation warnings, but they do not show their provenance. The attached patch provide improved warning messages by modifying the LineNumberingPushbackReader to include the source path of the file being read, so that it can be retrieved by the LispReader.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Assembla Importer added a comment -

Converted from http://www.assembla.com/spaces/clojure/tickets/234
Attachments:
0002-Modified-the-LineNumberingPushbackReader-to-include-.patch - https://www.assembla.com/spaces/clojure/documents/bmHcpC9Yur3RGweJe5afGb/download/bmHcpC9Yur3RGweJe5afGb

Show
Assembla Importer added a comment - Converted from http://www.assembla.com/spaces/clojure/tickets/234 Attachments: 0002-Modified-the-LineNumberingPushbackReader-to-include-.patch - https://www.assembla.com/spaces/clojure/documents/bmHcpC9Yur3RGweJe5afGb/download/bmHcpC9Yur3RGweJe5afGb
Hide
Permalink
Stuart Halloway added a comment -

Alan: please bounce this if incomplete, or screen if it seems simple enough.

Show
Stuart Halloway added a comment - Alan: please bounce this if incomplete, or screen if it seems simple enough.
Hide
Permalink
Alan Dipert added a comment -

The patch looks good, but as of 1.2 there are no longer any deprecated reader macros. This might be worth adding in case any macros are deprecated in the future.

Show
Alan Dipert added a comment - The patch looks good, but as of 1.2 there are no longer any deprecated reader macros. This might be worth adding in case any macros are deprecated in the future.
Hide
Permalink
Stuart Halloway added a comment -

If we ever have another deprecation, we should bring this back along with a test case.

Show
Stuart Halloway added a comment - If we ever have another deprecation, we should bring this back along with a test case.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4#649-r158309) | Report a problem
Powered by a free Atlassian JIRA open source license for Clojure. Try JIRA - bug tracking software for your team.