Clojure

Adding provenance of deprecation warnings to the LispReader

Details

  • Type: Enhancement Enhancement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Declined
  • Affects Version/s: None
  • Fix Version/s: Release 1.3
  • Component/s: None
  • Labels:
    None
  • Approval:
    Vetted

Description

The LispReader has some deprecation warnings, but they do not show their provenance. The attached patch provide improved warning messages by modifying the LineNumberingPushbackReader to include the source path of the file being read, so that it can be retrieved by the LispReader.

Activity

Hide
Assembla Importer added a comment -
Show
Assembla Importer added a comment - Converted from http://www.assembla.com/spaces/clojure/tickets/234 Attachments: 0002-Modified-the-LineNumberingPushbackReader-to-include-.patch - https://www.assembla.com/spaces/clojure/documents/bmHcpC9Yur3RGweJe5afGb/download/bmHcpC9Yur3RGweJe5afGb
Aaron Bedra made changes -
Field Original Value New Value
Reporter Assembla Importer [ importer ]
Priority Minor [ 4 ]
Waiting On aaron
Aaron Bedra made changes -
Assignee Nicolas Buduroi [ budu ] Aaron Bedra [ aaron ]
Aaron Bedra made changes -
Attachment 0234_LispReader_deprecation_provenance.patch [ 10051 ]
Waiting On aaron stu
Aaron Bedra made changes -
Hide
Stuart Halloway added a comment -

Alan: please bounce this if incomplete, or screen if it seems simple enough.

Show
Stuart Halloway added a comment - Alan: please bounce this if incomplete, or screen if it seems simple enough.
Stuart Halloway made changes -
Waiting On stu alan.dipert
Hide
Alan Dipert added a comment -

The patch looks good, but as of 1.2 there are no longer any deprecated reader macros. This might be worth adding in case any macros are deprecated in the future.

Show
Alan Dipert added a comment - The patch looks good, but as of 1.2 there are no longer any deprecated reader macros. This might be worth adding in case any macros are deprecated in the future.
Hide
Stuart Halloway added a comment -

If we ever have another deprecation, we should bring this back along with a test case.

Show
Stuart Halloway added a comment - If we ever have another deprecation, we should bring this back along with a test case.
Stuart Halloway made changes -
Status In Progress [ 3 ] Resolved [ 5 ]
Resolution Declined [ 2 ]
Aaron Bedra made changes -
Assignee Aaron Bedra [ aaron ]
Approval Test Vetted
Waiting On alan.dipert
Stuart Halloway made changes -
Status Resolved [ 5 ] Closed [ 6 ]

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: