sort and sort-by should retain meta

Description

sort and sort-by don't conceptually change the contents of their source. It would be useful if they retained meta while reordering their contents.

Patch: clj-2417.patch

Environment

None

Attachments

Activity

Gijs Stuurman
November 5, 2018 at 5:47 PM

Test fix as new ticket in https://dev.clojure.org/jira/browse/CLJ-2424

Alex Miller
November 4, 2018 at 2:35 PM

The patch has already been applied, can you make a new ticket?

Gijs Stuurman
November 4, 2018 at 1:49 PM

The original patch (clj-2417.patch) is missing the '(is ..' wrapping in the test, without which the test are run but failures not reported. clj-2417-fix-test.patch adds the missing wrapping as a separate patch. Another option is to fix this in the original patch and to re-apply it.

Alex Miller
October 22, 2018 at 3:12 AM

yup

Ghadi Shayban
October 21, 2018 at 8:49 PM

Alex, you may have forgotten the patch

Resize issue view side panel

Completed

Details

Assignee

Unassigned

Reporter

Alex Miller

Labels

Approval

Patch

Code and Test

Priority

Major

Affects versions

Release 1.10

Fix versions