Clojure

Add support for subsets and submaps to sorted Sets/Maps

Details

  • Type: Enhancement Enhancement
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None
  • Patch:
    Code and Test

Description

Currently we can have a subseq of a sorted-set|map-by, but this returns a seq and
not a Set or Map.
Implementing the interfaces java.util.SortedSet and java.util.SortedMap would give
us support for calling .subSet and .subMap.

Activity

Hide
Assembla Importer added a comment -
Show
Assembla Importer added a comment - Converted from http://www.assembla.com/spaces/clojure/tickets/248
Hide
Assembla Importer added a comment -

awizzard said: Another nice addition could be java.util.NavigableMap, though this is available only since Java 6.

Show
Assembla Importer added a comment - awizzard said: Another nice addition could be java.util.NavigableMap, though this is available only since Java 6.
Jim Blomo made changes -
Field Original Value New Value
Assignee Jim Blomo [ jim.blomo ]
Hide
Jim Blomo added a comment -

SortedSet-SortedMap-interfaces-248.diff 2012-05-10 is a first pass at the SortedMap interface. If there are no objections, I'll build on the SortedMap implementation to add SortedSet support.

Show
Jim Blomo added a comment - SortedSet-SortedMap-interfaces-248.diff 2012-05-10 is a first pass at the SortedMap interface. If there are no objections, I'll build on the SortedMap implementation to add SortedSet support.
Jim Blomo made changes -
Attachment SortedSet-SortedMap-interfaces-248.diff [ 11195 ]
Hide
Jim Blomo added a comment -

SortedMap-interfaces-248.diff 2012-05-10 supersedes the last diff. It implements and tests the SortedMap interface.

Additionally it includes tests for `sorted-map`, which didn't seem to be tested yet.

Show
Jim Blomo added a comment - SortedMap-interfaces-248.diff 2012-05-10 supersedes the last diff. It implements and tests the SortedMap interface. Additionally it includes tests for `sorted-map`, which didn't seem to be tested yet.
Jim Blomo made changes -
Attachment SortedMap-interfaces-248.diff [ 11225 ]
Jim Blomo made changes -
Attachment SortedSet-SortedMap-interfaces-248.diff [ 11195 ]
Hide
Jim Blomo added a comment -

SortedMap-SortedSet-interfaces-248.diff 2012-05-18 supersedes the last diff. It implements and tests both SortedMap and SortedSet.

(Concurrent)NavigableMap is not implemented because I think 1.5 is still targeted. In any case, it probably should have its own ticket.

Show
Jim Blomo added a comment - SortedMap-SortedSet-interfaces-248.diff 2012-05-18 supersedes the last diff. It implements and tests both SortedMap and SortedSet. (Concurrent)NavigableMap is not implemented because I think 1.5 is still targeted. In any case, it probably should have its own ticket.
Jim Blomo made changes -
Jim Blomo made changes -
Attachment SortedMap-interfaces-248.diff [ 11225 ]
Hide
Andy Fingerhut added a comment -

clj-248-SortedMap-SortedSet-interfaces-patch2.txt dated May 24, 2012 is simply an updated version of SortedMap-SortedSet-interfaces-248.diff dated May 17, 2012. The latter patch no longer applied cleanly.

The new patch combines what was internally multiple git commits into one, simply because it was easier for me to create the patch that way. I left out the addition of *.swp and *.swo files to the .gitignore file. Builds and tests cleanly on Oracle/Apple JDK 1.6 on Mac OS X 10.6.8.

Show
Andy Fingerhut added a comment - clj-248-SortedMap-SortedSet-interfaces-patch2.txt dated May 24, 2012 is simply an updated version of SortedMap-SortedSet-interfaces-248.diff dated May 17, 2012. The latter patch no longer applied cleanly. The new patch combines what was internally multiple git commits into one, simply because it was easier for me to create the patch that way. I left out the addition of *.swp and *.swo files to the .gitignore file. Builds and tests cleanly on Oracle/Apple JDK 1.6 on Mac OS X 10.6.8.
Andy Fingerhut made changes -
Andy Fingerhut made changes -
Patch Code and Test [ 10002 ]
Priority Blocker [ 1 ]
Hide
Andy Fingerhut added a comment -

I don't know why Priority changed to Blocker when I changed Patch to "Code and Test". I didn't try to do that – suspect that something with the web UI is doing that automatically somehow.

Show
Andy Fingerhut added a comment - I don't know why Priority changed to Blocker when I changed Patch to "Code and Test". I didn't try to do that – suspect that something with the web UI is doing that automatically somehow.
Andy Fingerhut made changes -
Priority Blocker [ 1 ] Minor [ 4 ]
Hide
Jim Blomo added a comment -

Added CLJ-1008 for NavigableMap interface enhancement.

Show
Jim Blomo added a comment - Added CLJ-1008 for NavigableMap interface enhancement.
Alex Miller made changes -
Fix Version/s Approved Backlog [ 10034 ]
Fix Version/s Backlog [ 10035 ]
Alex Miller made changes -
Fix Version/s Backlog [ 10035 ]

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated: