Clojure

Add non-interning keyword lookup function

Details

  • Type: Enhancement Enhancement
  • Status: Closed Closed
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: Release 1.3
  • Component/s: None
  • Labels:
    None
  • Approval:
    Ok

Description

I need a non-interning keyword lookup function. This is the much delayed patch discussed way back, see this discussion:
http://groups.google.com/group/clojure-dev/browse_thread/thread/670ab284e86e17fa/22f3ba493a93db8c?lnk=gst&q=keyword+lookup#22f3ba493a93db8c

Attached is a proposed patch to implement this. It's different from the patch in the above thread in three main ways: it's against a current branch, it includes a clojure wrapper (find-keyword), and it uses the name find in the keyword class instead of lookup.

It's currently interning symbols, which I'm not sure about. It might be better to have the keys of the keyword table be strings instead of symbols, but that's a more intrusive change. Also, the find-keyword function is in core, which I'm not sure is the right place for it either.

Activity

Hide
Assembla Importer added a comment -
Show
Assembla Importer added a comment - stu said: [file:cX8wGA1uer36T_eJe5cbLr]
Hide
Assembla Importer added a comment -

stu said: Second patch subsumes first and adds tests.

Brian: please make sure to create patches with git format-patch (see http://clojure.org/patches). I had to reconstitute your patch before I could edit it.

Show
Assembla Importer added a comment - stu said: Second patch subsumes first and adds tests. Brian: please make sure to create patches with git format-patch (see http://clojure.org/patches). I had to reconstitute your patch before I could edit it.
Hide
Assembla Importer added a comment -

stu said: Updating tickets (#276, #280, #378, #437, #448)

Show
Assembla Importer added a comment - stu said: Updating tickets (#276, #280, #378, #437, #448)

People

  • Assignee:
    Unassigned
    Reporter:
    Anonymous
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: