Clojure

protocol-ize with-open

Details

  • Type: Enhancement Enhancement
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: Backlog
  • Component/s: None
  • Labels:
    None
  • Patch:
    Code

Description

Good use (and documentation example) of protocols: make with-open aware of a Closable protocol for APIs that use a different close convention. See http://groups.google.com/group/clojure/browse_thread/thread/86c87e1fc4b1347c

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Assembla Importer added a comment -

Converted from http://www.assembla.com/spaces/clojure/tickets/308

Show
Assembla Importer added a comment - Converted from http://www.assembla.com/spaces/clojure/tickets/308
Hide
Permalink
Tassilo Horn added a comment -

Added a CloseableResource protocol and extended it on java.io.Closeable (implemented by all Readers, Writers, Streams, Channels, Sockets). Use it in with-open.

All tests pass.

Show
Tassilo Horn added a comment - Added a CloseableResource protocol and extended it on java.io.Closeable (implemented by all Readers, Writers, Streams, Channels, Sockets). Use it in with-open. All tests pass.
Tassilo Horn made changes -
Field Original Value New Value
Attachment 0001-Implement-CLJ-308-Added-a-CloseableResource-protocol.patch [ 10754 ]
Hide
Permalink
Tassilo Horn added a comment -

Seems to be related to Scopes (http://dev.clojure.org/jira/browse/CLJ-2).

Show
Tassilo Horn added a comment - Seems to be related to Scopes (http://dev.clojure.org/jira/browse/CLJ-2).
Hide
Permalink
Tassilo Horn added a comment -

Updated patch.

Show
Tassilo Horn added a comment - Updated patch.
Tassilo Horn made changes -
Attachment 0001-Added-ClosableResource-protocol-for-with-open.patch [ 10986 ]
Tassilo Horn made changes -
Attachment 0001-Implement-CLJ-308-Added-a-CloseableResource-protocol.patch [ 10754 ]
Andy Fingerhut made changes -
Patch Code [ 10001 ]
Priority Blocker [ 1 ]
Hide
Permalink
Andy Fingerhut added a comment -

Patch 0001-Added-ClosableResource-protocol-for-with-open.patch dated 08/Mar/12 applies, builds, and tests cleanly on latest master as of Apr 2 2012. Tassilo has signed a CA.

Show
Andy Fingerhut added a comment - Patch 0001-Added-ClosableResource-protocol-for-with-open.patch dated 08/Mar/12 applies, builds, and tests cleanly on latest master as of Apr 2 2012. Tassilo has signed a CA.
Hide
Permalink
Tassilo Horn added a comment -

Updated patch to apply cleanly against master again.

Show
Tassilo Horn added a comment - Updated patch to apply cleanly against master again.
Tassilo Horn made changes -
Attachment 0001-Added-ClosableResource-protocol-for-with-open.patch [ 11047 ]
Andy Fingerhut made changes -
Priority Blocker [ 1 ] Minor [ 4 ]
Tassilo Horn made changes -
Attachment 0001-Added-ClosableResource-protocol-for-with-open.patch [ 10986 ]

People

  • Assignee:
    Unassigned
    Reporter:
    Anonymous
Vote (3)
Watch (2)

Dates

  • Created:
    Updated:
Atlassian JIRA (v4.4#649-r158309) | Report a problem
Powered by a free Atlassian JIRA open source license for Clojure. Try JIRA - bug tracking software for your team.