Clojure

Vec test bugs.

Details

  • Type: Defect Defect
  • Status: Closed Closed
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: Release 1.2
  • Component/s: None
  • Labels:
    None
  • Approval:
    Ok

Description

There are a couple of bugs in the tests defined in clojure.test-clojure.vectors:

1. There are two definitions of test-vec (from different patches), so the second overrides the first.

2. The rand-replace function for the compare tests should use (rand-int 99) instead of (rand-int 100). Currently, if 99 is chosen, it will append to the end of the sequence instead of replacing the last element.

Activity

Hide
Assembla Importer added a comment -
Show
Assembla Importer added a comment - dsg said: [file:cXxBGuwl0r35ypeJe5cbLr]
Hide
Assembla Importer added a comment -

dsg said: Attached patch that should fix both issues.

Show
Assembla Importer added a comment - dsg said: Attached patch that should fix both issues.
Hide
Assembla Importer added a comment -

importer said: (In [[r:3f8be323e5b1c8ca3b51e946930174b90284ace7]]) Rename two vec-test to be distinct and fix upper bound on random sequence modifier, see #341

Signed-off-by: Stuart Halloway <stu@thinkrelevance.com>

Branch: master

Show
Assembla Importer added a comment - importer said: (In [[r:3f8be323e5b1c8ca3b51e946930174b90284ace7]]) Rename two vec-test to be distinct and fix upper bound on random sequence modifier, see #341 Signed-off-by: Stuart Halloway <stu@thinkrelevance.com> Branch: master
Hide
Assembla Importer added a comment -

stu said: Updating tickets (#310, #318, #341)

Show
Assembla Importer added a comment - stu said: Updating tickets (#310, #318, #341)

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: