Clojure

Enhance (vector-of) to populate vector

Details

  • Type: Enhancement Enhancement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: Approved Backlog
  • Component/s: None
  • Labels:
    None
  • Approval:
    Ok

Description

As discussed on clojure-dev at <http://groups.google.com/group/clojure-dev/browse_thread/thread/97137884bb33f8ee>, I would like to enhance (vector-of) so that it can create a populated vector. There are two ways to do this:

1. Like vector, take an arbitrary number of arguments used to populate the array.
2. Like vec, take a collection and use it to populate the array.

Attachments

  1. Text File
    enhance-vector-of.patch
    25/Feb/11 4:29 PM
    4 kB
    Daniel Solano Gómez
  2. Text File
    updated-enhance-vector-of.patch
    10/Mar/11 2:02 PM
    4 kB
    Daniel Solano Gómez

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Assembla Importer added a comment -

dsg said: [file:ciVMWWwl8r35ypeJe5cbLr]

Show
Assembla Importer added a comment - dsg said: [file:ciVMWWwl8r35ypeJe5cbLr]
Hide
Permalink
Assembla Importer added a comment -

dsg said: I have attached a patch that implements the proposed enhancement. I am fairly certain it is not the absolutely highest performance implementation.

I have not taken a lot of time to thoroughly study the code, but I think there is probably a way to create the initial array and pass it as an argument to the constructor, which would avoid a lot of the cons calls.

Nonetheless, I think it is important enough to provide convenience of the interface. The implementation can always be changed later.

Show
Assembla Importer added a comment - dsg said: I have attached a patch that implements the proposed enhancement. I am fairly certain it is not the absolutely highest performance implementation. I have not taken a lot of time to thoroughly study the code, but I think there is probably a way to create the initial array and pass it as an argument to the constructor, which would avoid a lot of the cons calls. Nonetheless, I think it is important enough to provide convenience of the interface. The implementation can always be changed later.
Hide
Permalink
Assembla Importer added a comment -

richhickey said: You can't have it both ways. vector-of should be like vector, I think.

Show
Assembla Importer added a comment - richhickey said: You can't have it both ways. vector-of should be like vector, I think.
Hide
Permalink
Daniel Solano Gómez added a comment -

I have updated my patch to reflect Rich's recommendation. vector-of now behaves similarly to vector.

Includes tests.

Show
Daniel Solano Gómez added a comment - I have updated my patch to reflect Rich's recommendation. vector-of now behaves similarly to vector. Includes tests.
Daniel Solano Gómez made changes -
Field Original Value New Value
Attachment enhance-vector-of.patch [ 10121 ]
Daniel Solano Gómez made changes -
Status In Progress [ 3 ] Open [ 1 ]
Stuart Halloway made changes -
Reporter Assembla Importer [ importer ]
Priority Minor [ 4 ]
Approval Test Screened
Hide
Permalink
Rich Hickey added a comment -

For the 1,2,3 cases it's better to create an array of that size and .aset am into it, please. & rest case could bootstrap with 3-arg call as well.

Thanks.

Show
Rich Hickey added a comment - For the 1,2,3 cases it's better to create an array of that size and .aset am into it, please. & rest case could bootstrap with 3-arg call as well. Thanks.
Rich Hickey made changes -
Approval Screened Incomplete
Hide
Permalink
Daniel Solano Gómez added a comment -

Updated patch to reflect Rich's suggestions.

Show
Daniel Solano Gómez added a comment - Updated patch to reflect Rich's suggestions.
Daniel Solano Gómez made changes -
Attachment updated-enhance-vector-of.patch [ 10143 ]
Daniel Solano Gómez made changes -
Approval Incomplete Test
Alan Dipert made changes -
Approval Test Screened
Waiting On stu
Rich Hickey made changes -
Approval Screened Ok
Stuart Halloway made changes -
Status Open [ 1 ] Closed [ 6 ]
Resolution Completed [ 1 ]

People

Vote (1)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4#649-r158309) | Report a problem
Powered by a free Atlassian JIRA open source license for Clojure. Try JIRA - bug tracking software for your team.