Details
-
Type:
Defect
-
Status:
Closed
-
Resolution: Completed
-
Affects Version/s: None
-
Fix Version/s: Release 1.2
-
Component/s: None
-
Labels:None
-
Approval:Ok
Description
Underive is incorrect: not all maps are updated, and the wrong key is used. See http://groups.google.com/group/clojure/browse_thread/thread/b70f8bf16de2216
Activity
Hide
Assembla Importer
added a comment -
stu said: The second patch adds (hopefully) improved tests, plus a third commit that is just some needed reorg of test helpers.
This may look like a big change during RC, but I am going to argue that it isn't really, because (1) it is entirely localized to underive, (2) introduces no new behavior, and (3) the current underive is trivially broken, so how could this be worse? 
Show
Assembla Importer
added a comment - stu said: The second patch adds (hopefully) improved tests, plus a third commit that is just some needed reorg of test helpers.
This may look like a big change during RC, but I am going to argue that it isn't really, because (1) it is entirely localized to underive, (2) introduces no new behavior, and (3) the current underive is trivially broken, so how could this be worse?
Converted from http://www.assembla.com/spaces/clojure/tickets/382
Attachments:
382_underive_and_tests.patch - https://www.assembla.com/spaces/clojure/documents/bjcuyUNgSr37DFeJe5cbLr/download/bjcuyUNgSr37DFeJe5cbLr
0382-underive-more-tests-and-reorg-helpers.patch - https://www.assembla.com/spaces/clojure/documents/aGQTwUOW4r36MseJe5cbLr/download/aGQTwUOW4r36MseJe5cbLr