Clojure

fix underive for multiple inheritance

Details

  • Type: Defect Defect
  • Status: Closed Closed
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: Release 1.2
  • Component/s: None
  • Labels:
    None
  • Approval:
    Ok

Description

Underive is incorrect: not all maps are updated, and the wrong key is used. See http://groups.google.com/group/clojure/browse_thread/thread/b70f8bf16de2216

Activity

Hide
Assembla Importer added a comment -

rob_lachlan said: [file:bjcuyUNgSr37DFeJe5cbLr]: Patch for underive fixing several issues, to core.clj. Also tests in multimethods.clj

Show
Assembla Importer added a comment - rob_lachlan said: [file:bjcuyUNgSr37DFeJe5cbLr]: Patch for underive fixing several issues, to core.clj. Also tests in multimethods.clj
Hide
Assembla Importer added a comment -
Show
Assembla Importer added a comment - stu said: [file:aGQTwUOW4r36MseJe5cbLr]
Hide
Assembla Importer added a comment -

stu said: The second patch adds (hopefully) improved tests, plus a third commit that is just some needed reorg of test helpers.

This may look like a big change during RC, but I am going to argue that it isn't really, because (1) it is entirely localized to underive, (2) introduces no new behavior, and (3) the current underive is trivially broken, so how could this be worse?

Show
Assembla Importer added a comment - stu said: The second patch adds (hopefully) improved tests, plus a third commit that is just some needed reorg of test helpers. This may look like a big change during RC, but I am going to argue that it isn't really, because (1) it is entirely localized to underive, (2) introduces no new behavior, and (3) the current underive is trivially broken, so how could this be worse?
Hide
Assembla Importer added a comment -

stu said: Updating tickets (#404, #422, #382, #423)

Show
Assembla Importer added a comment - stu said: Updating tickets (#404, #422, #382, #423)

People

  • Assignee:
    Unassigned
    Reporter:
    Anonymous
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: