Clojure

clojure tests can fail because of a race in the pprint tests

Details

  • Type: Defect Defect
  • Status: Closed Closed
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: Release 1.3
  • Component/s: None
  • Labels:
    None
  • Approval:
    Ok

Description

When I was doing the pprint tests for printing agents, I typod the code that guarded against races.

Bug was observed by Rasmus Svensson in http://groups.google.com/group/clojure-dev/browse_thread/thread/26b14bcada913247#

Example:

[java] FAIL in (pprint-datastructures-tests) (test_pretty.clj:226)
[java] expected: ((var
clojure.test-clojure.pprint.test-helper/back-match) (tst-pprint 20
(failed-agent)) #"#<Agent@[0-9a-f]+ FAILED: \n \"foo\">")
[java] actual: nil

Patch coming momentarily.

Activity

Hide
Assembla Importer added a comment -

tomfaulhaber said: [file:dzMEaqO-Kr36zXeJe5cbLA]: The patch to fix the bug

Show
Assembla Importer added a comment - tomfaulhaber said: [file:dzMEaqO-Kr36zXeJe5cbLA]: The patch to fix the bug
Hide
Assembla Importer added a comment -

tomfaulhaber said: I've added a patch that should fix the bug. I'll ask Rasmus to confirm.

Show
Assembla Importer added a comment - tomfaulhaber said: I've added a patch that should fix the bug. I'll ask Rasmus to confirm.
Hide
Assembla Importer added a comment -

tomfaulhaber said: Rasmus has confirmed that this indeed fixes the problem. I'd push for this change to go into 1.2 if anything more ends up going in, so that folks can run the tests reliably.

Show
Assembla Importer added a comment - tomfaulhaber said: Rasmus has confirmed that this indeed fixes the problem. I'd push for this change to go into 1.2 if anything more ends up going in, so that folks can run the tests reliably.
Hide
Assembla Importer added a comment -

stu said: Updating tickets (#427, #426, #421, #420, #397)

Show
Assembla Importer added a comment - stu said: Updating tickets (#427, #426, #421, #420, #397)
Hide
Assembla Importer added a comment -

stu said: Updating tickets (#421, #427)

Show
Assembla Importer added a comment - stu said: Updating tickets (#421, #427)

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: